Comments (1)
Hi Josh,
thanks for opening a dedicated issue for this! As mentioned in #20, my idea would be to create a new cleanup rule "Align components in tabular layout" (or similar), which would align cases such as …
DATA(var) = VALUE some_type( ( amount = '1.23' name = 'short' )
( amount = '123.4' name = 'longer' )
( amount = '1234.56' name = 'very long' ) ).
… into …
DATA(var) = VALUE some_type( ( amount = '1.23' name = 'short' )
( amount = '123.4' name = 'longer' )
( amount = '1234.56' name = 'very long' ) ).
… providing options on
- maximum allowed line length,
- whether to create such alignment from previous multi-line cases,
- whether to align decimal places (as done above),
- whether to align closing parentheses
- whether to put two spaces between a value and the next component name etc.
This would then also cover your example (even if the closing parenthesis would, admittedly, not be the focus of the rule). The options would also benefit cases with just one field if there are multiple rows, so you'd get:
DATA(var) = VALUE some_type( ( amount = '1.23' )
( amount = '123.4' )
( amount = '1234.56' ) ).
or alternatively:
DATA(var) = VALUE some_type( ( amount = '1.23' )
( amount = '123.4' )
( amount = '1234.56' ) ).
Kind regards,
Jörg-Michael
from abap-cleaner.
Related Issues (20)
- Bug for S/4 readiness check psuedo comments HOT 3
- Aligning single parameters for functional calls HOT 4
- Eclipse ADT - Update Site not reachable? HOT 3
- "Align parameters and components": Direct usage of structure looks weird in VALUE HOT 4
- BUG: Rules "Convert CHECK inside/outside loop..." HOT 5
- Differences with ABAP Formatter HOT 6
- "Align parameters and components" when using multiple indices in nested table expression HOT 4
- "Align conditional expressions": `THROW` not aligned nicely in `SWITCH` HOT 3
- "Align declarations": Line break if the line gets too long HOT 4
- Allow customization of `TODO` keyword HOT 2
- 'Align logical expression' does not recognize WHERE statement HOT 2
- RND parser categorizes as a CAT_LITERAL in ULINE length statement HOT 4
- "Align parameters and components": Options do not behave as expected HOT 5
- Feature request: Align FORM calls HOT 1
- Feature request: Align FORM definitions HOT 1
- Feature request: Standardize order of parameters when using `CL_ABAP_UNIT_ASSERT` HOT 1
- Feature Request: remove empty line-break(s) between ENDxxxxs. HOT 3
- "Delete unused variables": Incorrect result across multiple `TEST-INJECTION` blocks HOT 2
- Bug: "prefer_is_not..." in combination with "move and/or..." breaks when comments are present HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-cleaner.