Giter Site home page Giter Site logo

Comments (4)

jmgrassau avatar jmgrassau commented on June 29, 2024 2

Hi ConjuringCoffee,

thanks for this issue! I now added a new option to the "Align declarations" rule:

image

This changes

    DATA this_is_an_attribute TYPE lif_example_interface=>this_is_a_type_name VALUE lif_example_interface=>values_for_the_type-first_value.

into

    DATA this_is_an_attribute TYPE lif_example_interface=>this_is_a_type_name
                              VALUE lif_example_interface=>values_for_the_type-first_value.

or – if you'd only allow a maximum line length of 89 or less – even into

    DATA this_is_an_attribute TYPE lif_example_interface=>this_is_a_type_name
         VALUE lif_example_interface=>values_for_the_type-first_value.

This also works in the other direction, moving VALUE clauses behind the type if maximum line length allows for it.

Kind regards,
Jörg-Michael

from abap-cleaner.

jmgrassau avatar jmgrassau commented on June 29, 2024 1

Hi ConjuringCoffee,

the new option is now available with version 1.5.1 which was just released!

Kind regards,
Jörg-Michael

from abap-cleaner.

jmgrassau avatar jmgrassau commented on June 29, 2024

Hi ConjuringCoffee,

I haven't encountered such an example yet, but of course it makes sense to break the line here. So, I think an option for maximum line length should be added. However, where exactly would you expect VALUE to be moved? Maybe below TYPE? Or below the variable name?

Kind regards,
Jörg-Michael

from abap-cleaner.

ConjuringCoffee avatar ConjuringCoffee commented on June 29, 2024

I think the following two approaches would look good:

    DATA this_is_an_attribute TYPE  lif_example_interface=>this_is_a_type_name 
                              VALUE lif_example_interface=>values_for_the_type-first_value.
    DATA this_is_an_attribute TYPE lif_example_interface=>this_is_a_type_name 
                              VALUE lif_example_interface=>values_for_the_type-first_value.

from abap-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.