Giter Site home page Giter Site logo

Comments (3)

Myzumi avatar Myzumi commented on August 18, 2024

Can also Confirm this issue, errors are also the same.

using [email protected] , [email protected] (which depends on this)

from shapeshift.

imranbarbhuiya avatar imranbarbhuiya commented on August 18, 2024

The SchemaOf issue is easily fixable by adding extends NonNullable in SchemaOf but I tried to fix other type issues related to {} and I wasn't able to do it. The issue is coming from https://github.com/sapphiredev/shapeshift/blob/main/src/lib/util-types.ts#L10
before 4.8, it was {} & object but after 4.8, it's now object. The only solution that worked for me was removing extends NonNullableObject from https://github.com/sapphiredev/shapeshift/blob/main/src/validators/ObjectValidator.ts#L15 but that's not a solution as it'll now accept any values.

For now you can add skipLibCheck in your tsconfig or use typescript < 4.8

from shapeshift.

Didas-git avatar Didas-git commented on August 18, 2024

The SchemaOf issue is easily fixable by adding extends NonNullable in SchemaOf but I tried to fix other type issues related to {} and I wasn't able to do it. The issue is coming from https://github.com/sapphiredev/shapeshift/blob/main/src/lib/util-types.ts#L10 before 4.8, it was {} & object but after 4.8, it's now object. The only solution that worked for me was removing extends NonNullableObject from https://github.com/sapphiredev/shapeshift/blob/main/src/validators/ObjectValidator.ts#L15 but that's not a solution as it'll now accept any values.

For now you can add skipLibCheck in your tsconfig or use typescript < 4.8

I have been using skipLibCheck because of this, but its not the best thing to do.
About object, maybe a solution to this would be using Record<PropertyKey, unknown> which can be used to represent any object but might need some changes in other parts of the code.

from shapeshift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.