Comments (5)
I'm not sure where you draw the conclusion from that node_compat is discouraged? The docs don't mention any such thing: https://developers.cloudflare.com/workers/runtime-apis/nodejs
from shapeshift.
@favna the wrangler CLI mentions that node_compat has serious tradeoffs
also the plugin it uses is unmaintained
from shapeshift.
Regarding Wrangler using code from ionic, you'll have to take that up with Cloudflare. As for the usage of node:util
in this lib, we are very much aware of the issue, but at the same time personally, I have no idea how we can replace it. Possibly @kyranet who designed that part of the code can toss in some ideas. Alternatively, I'm not entirely sure why using @imranbarbhuiya's esbuild-plugins-node-modules-polyfill
does not replace var util = require('util');
/ import { inspect } from 'util';
from the CJS and ESM builds respectively when the plugin is activated for those bundles. That might be a way to achieve wrangler support as well.
That all said, I'm not sure if just replacing util is enough, because we also depend on:
import get from 'lodash/get.js';
import fastDeepEqual from 'fast-deep-equal/es6/index.js';
import uniqWith from 'lodash/uniqWith.js';
And outside of bundling all the code into the shapeshift bundle I don't see any way to replace those.
from shapeshift.
wrangler is also planning to use this plugin, maybe it'll solve the issue. see cloudflare/workers-sdk#3832 but they want to ship it as a breaking change so I am not sure if it'll happen anytime soon
from shapeshift.
Alternatively, I'm not entirely sure why using @imranbarbhuiya's esbuild-plugins-node-modules-polyfill does not replace var util = require('util'); / import { inspect } from 'util'; from the CJS and ESM builds respectively when the plugin is activated for those bundles.
We only enabled it for browser environments as node already have it. We can still make it to bundle for node env too
from shapeshift.
Related Issues (20)
- request: refactor code in order to rely less on type casting HOT 1
- Implement something like zod's nativeEnum HOT 1
- request: Implement something like zod's nativeEnum
- bug: `BaseValidator` return type is invalid
- bug: Reshape is in the docs, but is nowhere in the code HOT 2
- bug: BaseError is not correctly exported HOT 2
- bug: Object validators considers keys that have a default return value as required
- bug: shapeshift 3.5.0 imports fast-deep-equal wrong breaking it HOT 2
- bug: Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import HOT 4
- bug: Types not working with typescript 4.8 HOT 3
- request: Narrowing types from schema HOT 4
- request: `setValidationEnabled` should [un]wrap the validator into an `PartialValidator<T>`
- bug: Type 'T' does not satisfy the constraint 'object' HOT 1
- bug: Type 'T' does not satisfy the constraint 'object' HOT 3
- request: add `s.string.phone` to regex validate a phone number HOT 1
- request: Add label support to validators, constraints, etc HOT 1
- request: cloudflare worker support HOT 5
- question: Multiple errors causing my discord bot to crash HOT 2
- bug: UnionValidator#setValidationEnabled does not make its members respect that HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shapeshift.