sarahwie/refugee_migration_trends

a refugee migration visualization tool using data from the UNHCR up to 2015.

refugee_migration_trends's Issues

app is not rendering

Hey @sarahwie I can't seem to get your app to render. I think there are two problems that I can identify. One was requiring that you use the structure of keeping all your scripts in the ./scripts directory. You should definitely move the files server.R and ui.R into the main directory. After making that change I get this error:

Object length mismatch:
     wrd_sp has 184 Polygons objects, but counts_by_country has 235 rows

Alphabetize the country of origin list

this would just be a nice feature to add

Comments Round 2

General Review Checklist

Purpose

Is the purpose of the project is clear?
Yes, the README does a good job of explaining.

Is it clear what each file in the project is intened for?
Yes, the README even explained the order for opening the files.

It is clear how the various files interact?
Yes, README explains

Is it clear what the purpose if of specific sections of code?
Sort of, although there could be more layman's terms. I was a bit lost on how it all went together.

How well commented is the code on a scale of 1(no comments) to 10(very well commented).
I'd say 4, comments a bit vauge.

How can the purposes of the project and files be improved?
Maybe the code comments could walk people through how the app is put together. However, it might make sense to someone with more coding experience.

Organization

Is the project organized such that you can intuit where the data, scripts, and output files are stored?
Yes

Approximately how much time did it take you to understand the work flow in the project?
Not long at all

How well defined are code chunks in the project?
Code could be chunked out a little better.

How can organization be improved?

Functionality

Does the code appear to advance the purpose of the project?
Yes

Do the existing components of the project appear to function?

How can the author improve functionality of code?

Specific File Comments
Having trouble opening mapping_countries.csv. Otherwise the first file, cleanFunction.R, looks good.

README.md
(for example) Easy to understand, but consider adding a code licence...
Status API Training Shop Blog About

Country counts and country percentages not matching

The count patterns and the percentage patterns should be identical looking but some countries shaded on the percentages map are colored as white in the counts map which I think indicates there is a bug in the code.

General Review Checklist

General Review Checklist
Purpose

Is the purpose of the project is clear?
Sarah does a great job describing what the project produces. It might be helpful to provide the purpose/motivation of the project- just one or two sentences.

Is it clear what each file in the project is intened for?
Yes, Sarah did a great job organizing and describing each of the scripts, source and kind of data, and what her code will produce.

It is clear how the various files interact?
Yes

Is it clear what the purpose if of specific sections of code?
Yes. Sarah is very organized and does a great job explaining what each line of code does. This is helpful to her future self and to others that are interested in interpreting and using her code.

How well commented is the code on a scale of 1(no comments) to 10(very well commented).
10, great!

How can the purposes of the project and files be improved?
Add 1-2 sentences more about purpose/motivation

Organization
Is the project organized such that you can intuit where the data, scripts, and output files are stored?
Yes, great organization

Approximately how much time did it take you to understand the work flow in the project?
About 5 minutes

How well defined are code chunks in the project?
Very! Great job

How can organization be improved?
I suggest instructing the reader the order in which they should run the scripts, i.e., since it’s important to run the clean function script before the app script

Functionality
Does the code appear to advance the purpose of the project?
Yes, currently I am just getting an image of the map, but I think if Sarah is able to get the code to display the data like she plans, it will be an interesting and extremely useful project!

Do the existing components of the project appear to function?
Not yet, the display and app still need some work.

How can the author improve functionality of code?
If she is able to get the map to display