sardonyx-sard/dar-to-oar

DAR to OAR Converter for SkyrimSE(dar2oar)

Code time of the week (updated every 19:00 UTC)

🐱 My GitHub Data

📦 225.3 kB Used in GitHub's Storage

🚫 Not Opted to Hire

📜 37 Public Repositories

🔑 2 Private Repositories

I'm a Night 🦉

🌞 Morning                507 commits         ██░░░░░░░░░░░░░░░░░░░░░░░   07.08 % 
🌆 Daytime                2298 commits        ████████░░░░░░░░░░░░░░░░░   32.10 % 
🌃 Evening                1809 commits        ██████░░░░░░░░░░░░░░░░░░░   25.27 % 
🌙 Night                  2544 commits        █████████░░░░░░░░░░░░░░░░   35.54 % 

📅 I'm Most Productive on Monday

Monday                   1300 commits        █████░░░░░░░░░░░░░░░░░░░░   18.16 % 
Tuesday                  884 commits         ███░░░░░░░░░░░░░░░░░░░░░░   12.35 % 
Wednesday                1028 commits        ████░░░░░░░░░░░░░░░░░░░░░   14.36 % 
Thursday                 941 commits         ███░░░░░░░░░░░░░░░░░░░░░░   13.15 % 
Friday                   1154 commits        ████░░░░░░░░░░░░░░░░░░░░░   16.12 % 
Saturday                 767 commits         ███░░░░░░░░░░░░░░░░░░░░░░   10.72 % 
Sunday                   1084 commits        ████░░░░░░░░░░░░░░░░░░░░░   15.14 % 

📊 This Week I Spent My Time On

🕑︎ Time Zone: Asia/Tokyo

💬 Programming Languages: 
Markdown                 9 hrs               ████████████░░░░░░░░░░░░░   47.08 % 
Rust                     2 hrs 31 mins       ███░░░░░░░░░░░░░░░░░░░░░░   13.20 % 
JSON                     2 hrs 16 mins       ███░░░░░░░░░░░░░░░░░░░░░░   11.87 % 
Lua                      1 hr 7 mins         █░░░░░░░░░░░░░░░░░░░░░░░░   05.85 % 
C                        1 hr 5 mins         █░░░░░░░░░░░░░░░░░░░░░░░░   05.71 % 

🔥 Editors: 
VS Code                  19 hrs 7 mins       █████████████████████████   100.00 % 

💻 Operating System: 
Windows                  19 hrs 7 mins       █████████████████████████   100.00 % 

Last Updated on 04/05/2024 19:12:52 UTC

dar-to-oar's Issues

[Bug]: Wrong download link

Version

0.1.6

Unexpected behavior here

For some reason, cargo dist uses the repository name as URL with the same name as the binary name, and the resulting URL causes a not found.

Now the URL is dar2oar which is the same as the binary name.

Wrong
https://github.com/SARDONYX-sard/dar2oar/releases/download/0.2.2/dar2oar_cli-aarch64-apple-darwin.tar.xz

Expected behavior

Currect
https://github.com/SARDONYX-sard/dar-to-oar/releases/download/0.2.2/dar2oar_cli-aarch64-apple-darwin.tar.xz

The correct repository name is dar-to-oar.

If you can specify the URL yourself, this problem will be solved.
See: axodotdev/cargo-dist#236

Relevant log output

No response

[Feature]: asyncClosure field in ConvertOptions

Expected behavior

I wanted to put the conversion option progress report function in a field, but I couldn't.

• async_closure.rs

use core::future::Future;
use core::marker::PhantomData;

#[derive(Default, Debug)]
pub struct AsyncClosure<I, F, Fut, T>
where
    F: FnMut(I) -> Fut,
    Fut: Future<Output = T> + Send + 'static,
    T: Send + 'static,
{
    async_fn: Option<F>,
    _p: PhantomData<fn(I) -> Fut>,
}

impl<I, F, Fut, T> AsyncClosure<I, F, Fut, T>
where
    F: FnMut(I) -> Fut,
    Fut: Future<Output = T> + Send + 'static,
    T: Send + 'static,
{
    pub const fn new(async_fn: F) -> Self {
        Self {
            async_fn: Some(async_fn),
            _p: std::marker::PhantomData,
        }
    }

    pub fn apply(&mut self, x: I) -> Fut {
        match self.async_fn.as_mut() {
            Some(f) => f(x),
            None => async {},
        }
    }
}

• mod.rs

use std::future::Future;
use std::path::{Path, PathBuf};
use tokio::fs;
use tokio::io::{self, AsyncReadExt, AsyncWriteExt};
use tokio_stream::StreamExt;
use tracing::trace;

pub use mapping_table::read_mapping_table;
pub use sequential::convert_dar_to_oar;

#[derive(Debug, Default)]
pub struct ConvertOptions<'a, P: AsRef<Path>, I, F, Fut, T>
where
    F: FnMut(I) -> Fut,
    Fut: Future<Output = T> + Send + 'static,
    T: Send + 'static,
{
    /// DAR source dir path
    pub dar_dir: P,
    /// OAR destination dir path(If not, it is inferred from src)
    pub oar_dir: Option<PathBuf>,
    /// mod name in config.json & directory name(If not, it is inferred from src)
    pub mod_name: Option<&'a str>,
    /// mod author in config.json
    pub author: Option<&'a str>,
    /// path to section name table
    pub section_table: Option<HashMap<String, String>>,
    /// path to section name table(For _1st_person)
    pub section_1person_table: Option<HashMap<String, String>>,
    /// After converting to OAR, add mohidden to the DAR directory before conversion to treat it as a hidden directory. (for MO2 users)
    pub hide_dar: bool,
    pub async_fn: AsyncClosure< I, F, Fut, T>,
}

other

No response

[Bug]: I want to change the blank screen from white to black at startup.

Version

0.4.0

Unexpected behavior here

• Infomation
  tauri-apps/tauri#5170

I ran into a problem with main not showing up in the first place even after doing the following in Next.js and don't know how to fix it.
Waiting for implementation of tauri settings.

Expected behavior

Black launch screen

Relevant log output

No response

[Bug]: Mapping table options should be separated for 1st person and 3rd person

Version

0.1.0

Unexpected behavior here

unseparate for 1st person and 3rd person arg

Expected behavior

separate for 1st person and 3rd person arg

Relevant log output

No response

[Bug]: aysc multithreading is not really working.

Version

0.2.3

Unexpected behavior here

aysc multithreading is not really working.

tokio::spawn is necessary, but currently it is not possible to do efficient File I/O with multi-threading because the 'static lifetime could not be resolved.
https://earthly.dev/blog/rust-concurrency-patterns-parallel-programming/

Expected behavior

aysc multithreading.

Relevant log output

No response

[Feature]: `actions-rs/cargo@v1` is old. Recommend to change action

Expected behavior

Change actions-rs/cargo@v1
No longer maintained and still using Node.js12.

other

No response

[Feature]: async I/O

Expected behavior

Might be faster with asynchronous I/O

other

No response

[Bug](Core): Err skipping is unsafe.

Version

0.1.5

Unexpected behavior here

It does not return an error even if it never performs a conversion.

dar-to-oar/dar2oar_core/src/fs/sequential/mod.rs

Line 29 in 330041f

Err(_) => continue, // NOTE: The first search is skipped because it does not yet lead to the DAR file.

Expected behavior

Returns an error if the conversion was never performed.
But I don't know how to construct that flag (should I just use an AtomicBool?).

static IS_CONVERTE_EXECUTED_ONCE: AtomicBool = AtomicBool(false);

if !IS_CONVERTE_EXECUTED_ONCE.load(Ordering::Acquire) {
    bail!("DynamicAnimationReplacer dir was never found")
}

Relevant log output

No response