sauloxd/review-apps

Manage MULTIPLE static applications in your github-pages

review-apps's Issues

Skip creating index.html

We want to create review apps, but don't want to remove the existing index.html --- Can we have an option to skip index.html creation?

Action Breaks with Nested Branch Names

Hi, there!

We are using this action to deploy our review apps for Pull Requests and it is working quite nicely for the most part. The action runs and creates the new Github page successfully.

The problem comes right after the folder is successfully created in our gh-pages branch. It's trying to fetch the origin of the original PR branch and fails.

At first glance, it looks like it is only grabbing the branch name after the /.

For example... we have a branch called feat/migrate-to-github-actions. Creating a PR against our main branch, everything works perfectly fine. All of our tests run, the review app kicks off, and then creates our new folder in our gh-pages directory.

Then the action throws an error, because it's trying to fetch origin on migrate-to-github-actions and not feat/migrate-to-github-actions where our actual branch is. A real example error encounter and output can be seen below:

/usr/bin/git push origin gh-pages
To https://github.com/orgNameRedacted/repoNameRedacted
   86a2253..a75c6a5  gh-pages -> gh-pages
/usr/bin/git fetch origin migrate-to-github-actions
fatal: couldn't find remote ref migrate-to-github-actions
Error: The process '/usr/bin/git' failed with exit code 128
(node:14081) UnhandledPromiseRejectionWarning: Error: The process '/usr/bin/git' failed with exit code 128
    at ExecState._setResult (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:1026:25)
    at ExecState.CheckComplete (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:1009:18)
    at ChildProcess.<anonymous> (/home/vsts-agent/actions-runner/_work/_actions/sauloxd/review-apps/v1.3.3/packages/action/dist/index.js:903:27)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:430:11)
    at Socket.emit (events.js:210:5)
    at Pipe.<anonymous> (net.js:659:12)
(node:14081) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:14081) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

(I redacted org and repo name above since the is for a private setup)

Optional build-cmd

When running in GitHub Actions, the build-cmd is unnecessary, because I can just add a build step before the uses step. The build-cmd input also can't do things like cd demo && pnpm run build && touch .nojekyll, so I had to build it before the step and change the build-cmd to echo "Already built". It would be easier if I could just not specify build-cmd and it didn't run it.

Deprecated set-env

Seeing this error message, looks like you need to bump the @actions/core package maybe?

/usr/bin/git config --global user.name review-app-action-user
/usr/bin/git config --global user.email review-app-action-email
/usr/bin/git config pull.rebase true
Error: Unable to process command '::set-env name=PUBLIC_URL::<hidden>' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/