sawyerhood/animal-crossing-catch

Site to keep track of your critters in Animal Crossing

🛸 Sawyer here! I'm a software engineer who is currently exploring all of the weird ways we can interact with LLMs.

I'm currently building all of my experiments in public on twitter.

If you are working on something cool or just want to chat, feel free to reach out to me there!

animal-crossing-catch's Issues

Share collections

Is your feature request related to a problem? Please describe.
I am playing the game with friends and we are helping each other to fill their collections. Right now, the only way to do that is to take several screenshots of the application.

Describe the solution you'd like
A way to export the data to share it with friends. It may just be a txt file containing the names of all the items with titles like the ones in the app.

Feature Request: Flower collection

Maybe a checklist for collecting flowers?

With a guile of what color combinations to make each hybrid.

Resources are not sorted alphabetically

Describe the bug
The resources are not sorted alphabetically when not in english.

Screenshots

Desktop (please complete the following information):

• OS: Linux
• Browser : Chrome
• Version Ubuntu 18.04

Smartphone (please complete the following information):

• Device: OnePlus 6
• Browser Chrome

DIY checklist

Describe the solution you'd like
Like the other lists

Additional context
I think the search bar is a requirement on this one ...
And maybe some folding of the sections, so the page is not overloaded.

I can do the scraping, but I'm not familiar enough with React to do the page

Translations for Sea Creatures

@danilo-barboza added sea creatures for us! It would be radical to add support for our other languages.

HTML lang tag does not get changed when switching language

Describe the bug
When changing language the HTML lang tag does not get changed to the selected language.
For CJK (Chinese, Japanese, Korean) languages, if the HTML lang tag is not set, Chinese variant of some of the characters may be shown instead of the local variant which will feel somewhat out of place for those users.

To Reproduce
Steps to reproduce the behavior:

1. Go to site
2. Change language to Japanese
3. Wrong variant of characters are shown (HTML lang tag is set to "en")

Expected behavior
Change the HTML lang tag according to the language is set.

Screenshots
Chinese variant:

Japanese variant:

Desktop (please complete the following information):

• OS: Fedora Linux 32
• Browser: Firefox
• Version: 75

Smartphone (please complete the following information):

• Device: OnePlus 6
• OS: Android 10
• Browser: Chrome
• Version: 81

Incorrect catch data: Lobster and Spider crab

Describe the bug
Both the spider crab and lobster creatures are listed as available all year. But in fact, they are only available at certain periods:

Spider crab: March-April (Northern) / September-October (Southern)
Lobster: April-June, December-January (Northern) / October-December, June-July (Southern)

I've been using ac-catch since it's release and I wondered why I had caught everything this month (Northern Hemisphere) besides these two creatures after extensive diving, so I reached out to other websites to clarify their catch periods.

Several sites which list the correct catch duration data:

• https://www.polygon.com/animal-crossing-new-horizons-switch-acnh-guide/2020/7/2/21307259/diving-critters-sea-creatures-critterpedia-list
• https://www.ign.com/wikis/animal-crossing-new-horizons/Sea_Creatures_Guide%3A_Sea_Creature_List%2C_Sell_Price
• https://www.nintendolife.com/guides/animal-crossing-new-horizons-sea-creatures-complete-list-and-price-guide

To Reproduce

1. Visit ac-catch.com/
2. Navigate to Sea Creatures tab
3. View spider crab or lobster
4. See incorrect catch duration ("All year")

Expected behavior
Both the spider crab and lobster catch data should be updated:

Spider crab: N: "Mar - Apr"; S: "Sep - Oct"
Lobster: N: "Dec - Jan, Apr - Jun"; S: "Jun - Jul, Oct - Dec"

Screenshots
https://imgur.com/oMl315h

Desktop (please complete the following information):

• OS: Windows 10
• Browser Firefox
• Version 78.0.2

Smartphone (please complete the following information):

• Device: OnePlus6
• OS: Android
• Browser Firefox
• Version 68.10.1

Event Item Checklists

Is your feature request related to a problem? Please describe.
it would be helpful to have checklists for current/past events so one doesn't buy/craft duplicates on accident, especially with the wedding set items

Describe the solution you'd like
same sort of checklist as we have for other collectables except for event items

Describe alternatives you've considered
i've tried tracking via nookazon and just a text based list but both leave a lot to be desired

Additional context
I keep forgetting what items i've bought from the wedding shop, so i end up with extras and i fear i wont be able to get all the items.

New Horizons 2.0

With version 2.0, several new collectible songs were added, but are currently not represented here and can't be listed as collected.

It may also be worth considering adding a section on Gyroids as well.

Display Critter Rarity within the Cards

Is your feature request related to a problem? Please describe.
Would be nice to have a visualization of the rarity of a critter, otherwise you have to check the wiki each time.

Describe the solution you'd like
1-5 stars appearing somewhere within the card for the rarity of the critter, same as Wiki.
If the critter doesn't have a rarity associated with it display no stars.

Feature request: French and Japanese Translations

Is your feature request related to a problem? Please describe.
It would be awesome if it were possible to change language on the fly.

Describe the solution you'd like
Add a button to switch language.

Describe alternatives you've considered
None

Additional context
I am French but I play the game in Japanese. When talking with friends, I often have to switch from one language to another (French, English and Japanese) and I don't always remember the names in each language. Most sites don't have multiple languages.

Translation issues

I've found that there are some issues with the translations:

• I completed the Spanish translation and made a mistake with "Mahi-mahi", it's "Lampuga" instead. Source.
• What does "On Trees (Coconut?)" mean? I used the literal translation but doesn't make much sense to me.
• "On Rocks and Bushes (Rain)" is not translated in any language. In Spanish, it would be "En rocas y arbustos (con lluvia)".
• I think "River (Clifftop) Pond" is not easy to understand, what does it really mean?

Thanks in advance! Feel free to ask me if more translations are needed.

Search / filter

Is your feature request related to a problem? Please describe.
I'd like to be able to search or filter items in the grid.

Describe the solution you'd like
No need to go beyond simple string matching.

e.g. "blue" would match "Bluegill" and "Blue Marlin"
e.g. "blue m" would only match "Blue Marlin"
e.g. "pond" would match all fish catchable in the pond

Describe alternatives you've considered
Browser search is OK but I'd like the grid to filter to only the items that match the query.

Implementation wise, we could just filter the card before rendering them.

appState.rightNow.filter(currentFilter).map(catchableMapper)

Add support for the July update

Is your feature request related to a problem? Please describe.
I am going to guess that we will have new things that we can collect via diving with the July update. It would be good to add these in its own tab.

Describe the solution you'd like
The display should be just like fish

This would be a great feature for someone who would like to contribute!

Service worker on Safari uses excessive CPU?

Describe the bug
After resumption from 12h sleep, the ac-catch.com service worker pegged a CPU at near 100% on Safari

Desktop (please complete the following information):

• OS: MacOS Catalina 10.15.3
• Browser: Safari 13.0.5 (15608.5.11)

K.K. Slider Song List

A checklist for the collectable K.K. Slider songs available.

Mark as donated

Is your feature request related to a problem? Please describe.
I'd like to be able to mark something as donated to Blathers

Describe the solution you'd like
Another checkbox like the current "caught" checkbox that marks something as donated to Blathers.

Describe alternatives you've considered
Aside from the in-game Critterpedia... not a whole lot of options. Having both what you've caught and what you've donated in one place would be awesome.

Regression: Fossils are not translated anymore

Describe the bug
It seems the fossiles are not translated anymore (all languages except english)

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 18.04
• Browser Chrome

Smartphone (please complete the following information):

• Device: OnePlus 6
• OS: Android

Dependency vulnerabilities

Describe the bug
yarn audit and Snyk both report a few high severity vulnerabilities in the dependencies for this repo

Resources counts

Is your feature request related to a problem? Please describe.
I use the ac-catch to see what I already got, what I still need to fish/catch/etc.
I can see globally what's left to do, but a count of how many I got and how many I didn't would be easy to read and share.

Describe the solution you'd like
Add a count in parenthesis on the right of the section header.

Describe alternatives you've considered
Maybe the count on the left ?
Or at the top of the page after the "menu"

Support art collection

Is your feature request related to a problem? Please describe.
I would like a way to determine what art I have collected so far from Redd.

Describe the solution you'd like
I would like another tab (similar to Fish, Bugs, Fossils) which supports the art you can collect from Redd.

Some strings are not translatable

Some strings in the hamburger icon are not translatable. See here:

I think it doesn't make sense to have a mix of English and other languague.