Remove-RoboItem stops for input if robocopy fails to delete all sub items.

[sbergwall]

Remove-RoboItem stops for input if robocopy fails to delete all sub items.

[fjollberg]

Having thought one moment more on this, I think a preferrable solution would be in the order of:

Get-Item -Path $tempDirectory, $Location | ForEach-Object { $_.Delete() }

An error would stop with:

MethodInvocationException: Exception calling "Delete" with "0" argument(s): "The directory is not empty. : '\some\path"

[sbergwall]

This should be fixed in the dev branch with version 0.2.13, but I will continue to work on the error handling for this function.

There current is a non-breaking bug that I know of. Lets say we try to remove a folder containing a file and we do not have access to remove it, if we run Remove-RoboItem with -ErrorAction Continue the error that will be shown will say the error is from Invoke-Robocopy but will still remove the remaining files in the folder we have access to.

PS> Remove-RoboItem -Path "C:\folder"
Invoke-RoboCopy : Deleting Extra File C:\folder\log.txt. Access is denied.

If we instead use -ErrorAction Stop the error handling will be correct but no more files will be removed, even if we have access to do so.

PS> Remove-RoboItem -Path "C:\folder" -ErrorAction Stop
Remove-RoboItem : Deleting Extra File C:\C:\folder\log.txt. Access is denied.

The bug is that even if we use -ErrorAction Continue the correct name of the function should be shown in the error message.

[fjollberg]

Yes, it's a bit non-trivial. The issue with hanging scripts due to remove-item is fixed in dev, much appreciated.
But I'm still struggling a bit with error handling.

Currently, it seems like Remove-RoboItem returns on an error, but the Robocopy process is still running, causing the script to wait for the now seemingly detached process to die.

E.g. I get output such as this in some circumstances:
Apr 27, 2022 5:29 AM [error] ERROR: RETRY LIMIT EXCEEDED.. *EXTRA Dir -1 \Some\path\some\item
Apr 27, 2022 5:49 AM [error] Exception calling "Delete" with "0" argument(s): "The directory is not empty. : '\Some\path'"

After which my script proceeds to the end where it is waiting, and the robocopy.exe process is still running. I'm not 100% sure what it is doing at that point. Killing it causes the script to terminate.

My script proceeding also indicate that Remove-RoboItem returns with the property Success=$true.

I've added -InformationAction Ignore in order to get rid of a lot of ouput (these can be very, very large directory structures). I've now also added -ErrorAction Stop to see if that causes the script to properly detect an issue.

[sbergwall]

All this should be fixed in the master branch, version 0.2.15.