when line cannot be parsed, function may be called on null-valued expression in Invoke-RobocopyParser

[sbergwall]

when line cannot be parsed, function may be called on null-valued expression in Invoke-RobocopyParser

[sbergwall]

Hi @WiredSharp.

Can you please send the text that is not parsed?

[WiredSharp]

Hello,
here is an InputObject raising the previously mentioned error:
' 424 2022/10/11 13:40:54 E:\projects\Jee\lo.tools.jee\Tmp\modules\LO.Core\2.1.0\security\private\New-Credential2.ps1'

Notice that line has leading mix of tabs and spaces

BeforeDiscovery {
    $ModuleName = 'RobocopyPS'
    $ModuleBase = Split-Path -Parent $PSScriptRoot
    $ModulePath = Join-Path $ModuleBase -ChildPath $ModuleName

    # Removes all versions of the module from the session before importing
    Get-Module $ModuleName | Remove-Module
    Import-Module $ModulePath -PassThru -ErrorAction Stop
}
Describe "when parsing robocopy output" {
    InModuleScope $ModuleName {
        It "should not raise exception when parsing fails" -ForEach @(
            @{ line = '	  		     424 2022/10/11 13:40:54	E:\projects\New-Credential2.ps1';Source='E:\projects\New-Credential2.ps1' }
        ) {
            { Invoke-RobocopyParser -InputObject $line } | Should -Not -Throw
        }
    }
}

[skaravos]

Another case that will trigger this same code path occurs when specifying a logfile that resides inside the 'Source' directory.
(***Normally you wouldn't put the log in the source dir, but when copying a single file it's technically safe)

For example:

Invoke-Robocopy -Source "C:\tmp\src" -Destination "C:\tmp\dst" -Files "abc.txt" -LogFile "C:\tmp\src\robocopy.log" -Force

The first line of output from robocopy.exe is something akin to:

 Log File : C:\tmp\src\robocopy.log

Because this log file line matches *$Source* it enters the wrong branch and triggers the 'You cannot call a method on a null-valued expression.'
The offending line is here:

RobocopyPS/RobocopyPS/internal/Invoke-RobocopyParser.ps1

Line 86 in d34253d

ElseIf ($InputObject -like "*$($Source.Replace('[','`[').Replace(']','`]'))*") {

I've only briefly tested @WiredSharp's PR, but it seems to work perfectly and has also inadvertently solved this logfile bug!

[sbergwall]

Hi.

This is merged to master in Github, will push it to the Powershell Gallery as soon as possible. Thank you @WiredSharp for your help, much appreciated!

[sbergwall]

Hi.

This is now released to Powershell Gallery with version 0.2.19.