sbooth/max

An audio converter and CD ripper

max's Issues

when using with Itunes there are file "read errors"

Seems to be a bug related to the apple script

Add to iTunes Library.scpt

you need to add a "delay"
`tell application "iTunes"

	set library_source to first source whose kind is library
	set audio_item to (add audio_file to library_source)
	if playlist_name is not equal to "" then

`

tell application "iTunes"

	set library_source to first source whose kind is library
	set audio_item to (add audio_file to library_source)
	delay 10
	if playlist_name is not equal to "" then

10 seems to fix everything I have come across so far, less than this still throws errors on large number of file imports..

Provide a 64-bit build

With the release of macOS 10.13.4, macOS starts warning users about the coming drop of support for running 32-bit apps without compromise: https://support.apple.com/en-ca/HT208436

I just got this warning today with Max (an indispensable tool in my opinion, thanks for making it by the way!). It might be a good idea to update the app to build for 64-bit architectures.

Commits worth taking a look at

@sbooth Some fixes/changes/features that may be worth cherry picking:

https://github.com/doshidak/Max/commits/master
https://github.com/mengdaming/Max/commits/master

Feel free to close and thanks for the comeback, Stephen.

When it actually works

Column identifiers used with NSTableView autosave feature must conform to NSCoding protocol: (null)

Update of Max to work with macOS Monterey

If this would be in any way possible I would greatly appreciate it

Thanks

can't encode mp3s from 24 bit

Max version 0.9.2b2 doesn't seem to be able to process 24-bit audio into MP3 correctly. Whatever the samplerate, 24-bit audio gets encoded into total silence. It will encode properly to other formats besides MP3, and 16-bit audio seems to pass through everything just fine.

Merge Album art and Metadata panes

Could the album art selector be combined with the Metadata editor? That way, users don't have to switch back and forth between these panes.

Max no longer opening main window

Until the other day, when I've opened Max, it's presented me with a window into which I can drag the files I want to convert. Now that window no longer appears, and I can't figure out how to open it. I've tried the File/Open… menu option, but the files I want to convert (from WAV to FLAC) are greyed out, so I can't convert them. I've tried reinstalling the app, but it didn't help. Many thanks.

Using Mac OS 10.12.6 Sierra.

Cannot select quality of Core Audio encoding, defaults to Minimum

As of 10.11 (El Capitan), the quality selection for Core Audio encodings is nonfunctional. "Minimum" quality appears selected by default and is unchangeable.

See here for the same report by another user: http://forums.sbooth.org/viewtopic.php?f=4&t=98737

macOS Catalina update?

Hey guys, I just installed Catalina and sadly they don't allow Max to run anymore. How can I survive with the best wav to mp3 converter that exists?

Convert Acknowledgments.rtf to markdown

It may be worth converting Acknowledgments.rtf to markdown. The idea being that when viewed in GitHub it would render properly, rather than requiring a download and finding another tool.

Sourcing frameworks?

I was looking to see how to bootstrap the projects with the frameworks needed. Is there a process or is it manual. If the latter, would you be interested in using something like CocoaPods?

Trying to encode tracks from a CD fails, "The call to AudioFileCreateWithURL failed."

• Max 0.9.2b1 (25)
• macOS Catalina 10.15.3 (19D76)

Attempting to encode a track from CD to either ALAC or FLAC (didn't try more) fails with the error message The call to AudioFileCreateWithURL failed.

Can't build on Xcode 12.4

Getting the following error:

[NSDecimalNumber Length]:unrecognized selector sent to instance

It seems it's the number formatter for the progreess field, but can't seem to fix it my end.

Happens in encoder.xib and ripper.xib

Big Sur, M1

I can report that MAX is working on my M1 Mac. My only issue is adding output files to iTunes, since iTunes is no longer a thing. Probably has been an issue since Catalina, but I just now upgraded from Mojave to Big Sur, so I wouldn't know. I Skipped Catalina... Cheers!

Non-square cover art images shown as incredibly tiny previews

Images used as album art, that are not square, now display as really small previews in the album art viewer.

flac duration / header issues

Hi - I'm using Max Version 0.9.2b4 (25) on Big Sur. I recently updated to this version after leaving Mojave and needing to update the version of Max (64 bit presumably?).

I'm having issues with the way Max creates flacs - whether via transcoding or via ripping of CD. The symptom is that the flacs it creates confuse VLC and other players - they can't detect the length of the song. They'll play, but you can't fast forward or navigate through a song. I also noted that other header information doesn't seem to be written to the flac either. A little googling tells me that if the header is missing or incomplete this can occur? But that's the extent of my knowledge.

I tried (ripping and just transcoding) transcoding to mp3 and to wav and those behave as you'd expect so it seems like it's limited to flac.

I was able to use XLD to transcode to flac and the flac behaves appropriately in VLC, so it isn't something global on my system.

Thanks!

Empty array returned from MusicBrainz query if JSON key "releases" is missing.

Performing this query:

http://musicbrainz.org/ws/2/discid/CPuVKAnEu8JT0qUWkzcdMV7wHXA-?inc=artists+labels+recordings+release-groups+artist-credits&fmt=json

with Google Chrome resulted in this:

{
"id":"CPuVKAnEu8JT0qUWkzcdMV7wHXA-",
"track-count":12,
"artist":"Sleeper",
"barcode":"0078221882422",
"tracks":[{"title":"Feeling Peaky","length":173293,"artist":null},{"length":269973,"title":"Sale of the Century","artist":null},{"artist":null,"title":"Dress Like Your Mother","length":153000},{"title":"Statuesque","length":203560,"artist":null},{"artist":null,"title":"Nice Guy Eddie","length":200600},{"artist":null,"title":"Stop Your Crying","length":215906},{"title":"Lie Detector","length":152093,"artist":null},{"artist":null,"length":221800,"title":"What Do I Do Now?"},{"title":"Shrinkwrapped","length":286440,"artist":null},{"artist":null,"title":"Good Luck Mr. Gorsky","length":245733},{"artist":null,"title":"Factor 41","length":177333},{"artist":null,"length":172933,"title":"Click...off...gone"}],
"disambiguation":"",
"title":"The it Girl"
}

As there is no "releases" key in this result, PerformMusicBrainzQuery returns an empty array. The lack of a "releases" key is likely due to changes on the MusicBrainz server.

Issue with Mac OSX Encoding Audio Files

I have been trying to encode metadata onto audio files (music) with artist info, album info, cover image, etc. The files are originally WAV. I am trying create encoded MP3s at 320kbps, but every time I export them from Max, the audio files have no sound. This problem has persisted for certain albums, but I am fairly certain I did one a few weeks ago no problem.

I am currently running Mac OS 10.15.4, and using the 64-bit version of Max for Mac. Any guidance on this would be much appreciated, as I have to do this frequently for work and it's very convenient to both convert to MP3 and encode the metadata in one go. I just had to convert them first and then once they were MP3s I was able to get metadata encoded and the sound worked. Very odd.

Allow providing MusicBrainz link for metadata

I realize it's a longshot that you'll even read this @sbooth, but:

I have a newly released CD that Max is unable to find in the MusicBrainz database. However, the release is there and populated -- https://musicbrainz.org/release/5a76e9f4-9f95-4104-a7c0-0b3dfc6e82c6. It would be helpful if we could provide the XML link for a release such that Max will populate all of the metadata.

Thank you for the work you've done on this tool. I dread the day it stops working due to some macOS or hardware update. It's a far better ripper than iTunes/Music/Whatever-Apple-Calls-Their-Tool-Today.

Add README.md

It would be useful to add a README.md to the project.

I imagine it duplicating some of the information on the main website and then adding more in depth information on building the project.

Max and OSX Catalina?

Hello,

I went looking for a FLAC ripper for CDs today and found MAX Max 0.9.2b4. But Catalina OSX 10.15.7 is unhappy.

"“Max.app” can’t be opened because Apple cannot check it for malicious software."

Is there a simple fix?

thanks dc

Migrate notifications to NotificationCenter

In recent versions of the OS Apple has offered 'NotificationCenter' as an equivalent to Growl. Examine replacing Growl with NotificationCenter.

AudioMetadata.mm fails to build from source in xcode 6.2 under MacOS 10.9

I get the error: Cannot initialize return object of type 'NSString *' with an rvalue of type 'NSNumber *'
on lines 333, 340, 370,377:

333: (NSString _) trackDate { return [[_trackDate retain] autorelease]; }
340: (NSString *) albumDate { return [[albumDate retain] autorelease]; }
370: (void) setTrackDate:(NSString)trackDate { [_trackDate release]; _trackDate = [trackDate retain]; }
377: (void) setAlbumDate:(NSString *)albumDate { [_albumDate release]; _albumDate = [albumDate retain]; }

I see that album and track "Year" are used elsewhere. Is this a conversion between "Year" and "Date" that didn't get consistently applied when the repository was recovered.

I'd very much like to communicate with others who are building Max from source.

Crashes whenever it uses internet (0.9.2b2)

Hi!

I'm on macOS 10.14.6 Mojave and Max 0.9.2b2 always crashes whenever it uses internet. Wheter it's MusicBrainz or trying to fetch a cover. Checking for a new version works as expected though.

Anything i can do to help track this down?

I am in a WiFi network using a proxy (via auto discovery), but even if i completely deactivate the proxy Max crashes.

And of course, when i try to reproduce it, it doesn't crash (it crashed EVERY DAMN TIME I TRIED IT BEFORE!). As if it knew that i'll going to report that.

Anyone else experienced such a crash?

Migrate language files to iso2 naming

Trying to build with XCode 11.2.1 on maxOS 10.15.1, I get the following warnings:

Max/Max.xcodeproj Migrate “Spanish.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “Italian.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “French.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “Dutch.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “Japanese.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “English.lproj” (Deprecated)
Max/Max.xcodeproj Migrate “German.lproj” (Deprecated)

With the detailed warning indicating they should be renamed to their iso2 equivalents, such as 'es.lproj' and 'en.lproj'.

How to download released binaries?

I noticed that the website appears to be down at the moment https://sbooth.org/Max/ (error message 403 Forbidden). Is there an alternate place to download compiled releases?

If there is anything I could do to help, I would be delighted. Max is a wonderful piece of software! I think I've been using Max for over 10 years or so, and it is one of the best apps I know of.

Max no longer encoding genres properly in mp3 files

Genres are being encoded as unmarked.

macOS 10.12.6 breaks Max

I can't get the app open ever since I updated macOS to 10.12.6.

The app shows up as a process, but no GUI components ever show up on the screen.

Thanks

Gatekeeper keeps Max from starting

Sierra has done away with the "download apps from anywhere" option, therefore, Max won't get past the Gatekeeper anymore. (For some odd reason, the exception you can grant by hitting a key after Gatekeeper said "no" does not work for Max.)

As a workaround, it's possible to disable the Gatekeeper very temporarily:

1. sudo spctl --master-disable
2. launch Max
3. sudo spctl --master-enable

Subsequent launches don't require this workaround anymore.

Multi-disc collections crash when querying Musicbrainz

max-0.9.2b3

I was specifically trying to encode https://musicbrainz.org/release/198e0fd8-d98f-49f6-8f85-40a0167a05f1

When I would click on the musicbrainz icon to get the track names it would immediately crash.

Problem using MusicBrainz data for 2 cd release

I'm new to Max. I'm trying to rip Performing This Week… Live at Ronnie Scott’s (Deluxe Edition).

It's a two disk release. The first disk went perfectly; I was offered several matches from MusicBrainz, chose the Deluxe set, and away I went.

I'm having trouble with the second disk. Max finds the correct release, but doesn't seem to understand that it's the second disk of the set instead uses the title info for the first 12 of 16 tracks from the first disk.

Is there a way that I can get to Do The Right Thing?

An error occurred while encoding the file

[NOTE: this exception originated in the server.]
*** -[__NSArrayM objectAtIndex:]: index 0 beyond bounds for empty array

Incompatible with macOS Sonoma v14.2.1

Unable to install the application on macOS Sonoma v14.2.1

Support MacOS Big Sur

Dear sbooth,

I've use you app a lot of times. I just updated my mac to big sur. Now your app is not supported anymore. Could you please update it?

All the best,
Jaap Sijben

Website/download links down?

When trying to open the page https://sbooth.org/Max/ I get "403 Forbidden".

File download from https://files.sbooth.org/ fails completely with "server not found"

new macbook, can't use Max

just got a new MBP running Monterey. i downloaded Max 9.1 & it wont run. i get this error. please help

Version skew with mp4v2 framework causes fail to build from source.

The mp4v2 SVN repository has been archived. Apparently code.google.com is no longer a read/write community. It is unclear whether mp4v2 is now orphaned, or if there is a new definitive upstream for it.

The current issue with Max is version skew:

The build instructions under sbooth/AudioFrameworks say to check out SVN revision 501. This corresponds to mp4v2-2.0. However the API used in Max seems to be 1.9.0, and the API is different.

As documented at:
http://mp4v2.googlecode.com/svn-history/r434/doc/1.9.0/api/group__mp4__file.html
1.9.0 defines the calls to have a verbosity flag that is no longer in the definitions found in file.h
from the 2.0.0 distribution.

The MP4_DETAILS bitmasks are also gone.
MP4_DETAILS_ALL
MP4_DETAILS_ERROR
MP4_DETAILS_WARNING
MP4_DETAILS_READ
MP4_DETAILS_WRITE
MP4_DETAILS_FIND
MP4_DETAILS_TABLE
MP4_DETAILS_SAMPLE
MP4_DETAILS_HINT
MP4_DETAILS_ISMA
MP4_DETAILS_EDIT

I presume that since the last distribution of Max was a 2009 build, that 1.9.0 was canon then and that's what Max was built with. Unfortunately, the mp4v2 project under AudioFrameworks won't build from 1.9.0 source. There are missing source files, and we get a semantic error:

.../AudioFrameworks/mp4v2/mp4v2-src/src/bmff/typebmff.cpp:38:49: Cannot define or redeclare 'data' here because namespace 'bmff' does not enclose namespace 'Enum<mp4v2::impl::bmff::LanguageCode, 0>'