sbtqa/api-factory

Java framework for functional Api test automation in the BDD style

api-factory's Issues

Design flaw @ RestEntityImpl

api-factory/src/main/java/ru/sbtqa/tag/apifactory/rest/RestEntityImpl.java

Line 122 in ec228e8

if (response.getStatusLine().getStatusCode() != 200) {

I would remove this check completely. I might want to check exact status code (whether it's 404 or 500 matters a lot for example) and assert the content (which now you can't access at all). In my case, it's Created 201 and I can't check the content which I need.

Callback

We need to refuse to use javafx callback

update in pom qa-utils

update in pom qa-utils

Refact RestEntityImpl with performRequest

Add supporting URLParam

In some get requests we have variable params in url, best sample is search request.
Add new annotation and support it in code

No info about SSLHandshakeException

If you try to connect by https to a site with the unknown/untrusted certificate you get SSLHandshakeException deep down in the guts. All user can see is null as a response message.

Upgrade reflection methods

Need to update reflection methods (such as getApiEntry()). This methods should use guava-19.0 and higher.

Fix parameter in template filling

If parameter is null and template require this parameter filling then there are NPE

Add constants for api methods

Use constants as:
@ApiAction(method = HTTP.GET, title = "получить пост", path = "posts?id=%id")

Encoding isn't set in RestEntityImpl for response

api-factory/src/main/java/ru/sbtqa/tag/apifactory/rest/RestEntityImpl.java

Line 135 in d059df4

return new Bullet(headersResponse, EntityUtils.toString(response.getEntity()));

Actually, the same encoding for both response and request isn't that flexible.

x-www-form-urlencoded support

I tried to bound my x-www-form-urlencoded parameters with corresponding annotation (@ApiRequestParam) but it fails to send the request by casting Map to String.
Right here: https://github.com/sbtqa/api-factory/blob/5665d2f272e2f88d66d29e6c4977b38b0427e8f9/src/main/java/ru/sbtqa/tag/apifactory/rest/RestRawImpl.java#L83
I don't understand how it supposed to work with any kind of params tbh.

Add request repository

a la ResponseRepository

Downgrade to java 7

unexpected syntax changes

now we use () instead of "" when we want to specify page where the request will be sent.
this is different from page-factory syntax.