scarchik/opentsdb-py

Python client for OpenTSDB

opentsdb-py's Issues

Specify Timestamp instead of forced time.time()

Hi,

First, thank you for your work.

You need to know that I'm not familiar with OpenTSDB, but anyway I need to make it compatible with my current project and I want to use your library for that. I have a problem with your way to handle timestamp in the send function.

def send(self, name: str, value, **tags) -> dict:
        tags.update(self.static_tags)
        if self.host_tag is True and 'host' not in tags:
            tags['host'] = socket.gethostname()

        self._validate_metric(name, value, tags)
        metric = dict(metric=name, timestamp=int(tags.pop('timestamp', time.time())), value=value, tags=tags)

        if not self._close_client.is_set():
            self._push_metric_to_queue(metric)

return metric

I can see that you are doing a "time.time()", do you think there would be a way to make it configurable ?

Something like that:

def send(self, name: str, value, **tags, timestamp=time.time()) -> dict:
        tags.update(self.static_tags)
        if self.host_tag is True and 'host' not in tags:
            tags['host'] = socket.gethostname()

        self._validate_metric(name, value, tags)
        metric = dict(metric=name, timestamp=int(tags.pop('timestamp', timestamp)), value=value, tags=tags)

        if not self._close_client.is_set():
            self._push_metric_to_queue(metric)

return metric

And allow the user to specify the timestamp when using Gauge (for example)

tsdb.ACTIVE_USERS.set(12, timestamp=my_personal_timestamp)

Thank you !

Too many http requests in case of HTTPPushThread

While testing package I noticed that TSDBClient.queue_size() doesn't exceed 12. Therefore metrics are sent too often.
There should be an attribute in TSDBClient (i.e. send_metrics_batch_min - minimal metrics batch size) and supported in HTTPPushThread or other changes in order to be able to collect metrics into batches big enough to lower network traffic and increase performance of the server which is monitored

Kerberos environment

I have OpenTSDB inside a krb5 environment. I am starting a research to know how supporting krb5 with your lib.

Did you have do it before? Thanks.

How to use our client to get opentsdb data

I can't use your potsdb package to get opentsdb data . I want use your potsdb client to read data from opentsdb ,then use python for data model