schmaga/mediatr.extensions.microsoft.aspnetcore

Some useful extensions to make integration of MediatR into ASP.NET Core Applications easier

mediatr.extensions.microsoft.aspnetcore's Issues

Link RequestAborted CancellationToken with the one from MediatR methods

Hi!

Currently the library chooses only one cancellation token, with the RequestAborted being first priority.
This can, potentially, break client developer's code, where an explicit cancellation token is passed to MediatR methods calls as it will have no effect.

My suggestion is:

• If there is current HttpContext and MediatR method token is != default, then create a linked token source from both. After the await _mediator.Send/Publish the CancellationTokenSource should be disposed so that memory leaks will be avoided.
• If there is current HttpContext and MediatR method token is == default, then pass only RequestAborted down the chain
• if there isn't current HttpContex then pass only the MediatR method token

Also, this may be for annother issue, but since this is library code, there should be .ConfigureAwait(false) after every await, as per Stephen Cleary blog