schulik/aiolos

1-D hydrodynamics code for planetary atmosphere accretion and escape simulations

aiolos's Issues

Gravity bug

The enclosed mass calculation is not correct - it does not include contributions from previous cells unless self-gravity is turned on. Also, the mass in a single volume should be computed as density * volume, i.e. density * (r_{i+1}^3 - r_i^3) / 3. Factors of 4 * pi can be ignored entirely in a spherical code. See here:

aiolos/source.cpp

Line 53 in 7c3ccea

enclosed_mass[i] = enclosed_mass[i-1] + 4. * 3.141592 * x_i12[i] * x_i12[i] * (x_i[i]-x_i[i-1]) * u[i].u1; //Straightfoward integration of the poisson equation