[BUG] invalid sitemap urls on multi site instances

[schweriner]

[BUG] invalid sitemap urls on multi site instances

[Schweriner]

Indeed a bug that should not happen if no rootline is configured in the constants. Did you configure a rootline for your sitemap in the extension constants?

[helsner]

No i did not, but i know of the setting.
I would guess, that i would have to define that for all sites? We have a customer with around 100 pagetree segments, that are all small sites but would like to use that.

Best case would be, that the request automatically detects the Site i'm on, what to you think?
In my case is now used the already used TYPO3_REQUEST like follows:

/** @var Site $site */
$site = $GLOBALS['TYPO3_REQUEST']->getAttributes()['site'];
$copyrightReferences = $this->findForSitemap((string) ($site->getRootPageId() ?? ''));

[helsner]

maybe in case of the extension one could adapt and have the Site method as fallback in case rootlines is empty.
Also this can be limited to the sitemap functionality.
I cannot think of a case where there is more than one rootline wanted for the sitemap tbh, but i value your opinion as maintainer here, maybe you got better insights!

[Schweriner]

I pushed a possible solution for multi-domain sitemaps but indeed maybe it makes sense to only detect the images of the current page. I will read a little bit about the sense of a image sitemap which contains images of other domains...

[helsner]

ah! it does not contain images of other domains, but actual pages.
So the listing of the images is wrong as well as the page their related to

[Schweriner]

It should contain all images within one rootline or all rootlines if defined, located to the page where they are used.