Comments (6)
Indeed a bug that should not happen if no rootline is configured in the constants. Did you configure a rootline for your sitemap in the extension constants?
from tgm_copyright.
No i did not, but i know of the setting.
I would guess, that i would have to define that for all sites? We have a customer with around 100 pagetree segments, that are all small sites but would like to use that.
Best case would be, that the request automatically detects the Site i'm on, what to you think?
In my case is now used the already used TYPO3_REQUEST like follows:
/** @var Site $site */
$site = $GLOBALS['TYPO3_REQUEST']->getAttributes()['site'];
$copyrightReferences = $this->findForSitemap((string) ($site->getRootPageId() ?? ''));
from tgm_copyright.
maybe in case of the extension one could adapt and have the Site method as fallback in case rootlines is empty.
Also this can be limited to the sitemap functionality.
I cannot think of a case where there is more than one rootline wanted for the sitemap tbh, but i value your opinion as maintainer here, maybe you got better insights!
from tgm_copyright.
I pushed a possible solution for multi-domain sitemaps but indeed maybe it makes sense to only detect the images of the current page. I will read a little bit about the sense of a image sitemap which contains images of other domains...
from tgm_copyright.
ah! it does not contain images of other domains, but actual pages.
So the listing of the images is wrong as well as the page their related to
from tgm_copyright.
It should contain all images within one rootline or all rootlines if defined, located to the page where they are used.
from tgm_copyright.
Related Issues (20)
- composer support HOT 2
- Language Handling for Image sitemap? HOT 13
- [FEATURE] Add optional sorting by reference title
- Generated image sitemap returns images that are related to disabled/hidden tt_content records HOT 1
- Version for LTS 10 HOT 2
- Data truncated for column 'copyright' at row 1 HOT 1
- remove dependency to filemetadata? HOT 5
- Tag version in Packagist HOT 3
- Extension can not be loaded with composer HOT 2
- Sitemap invalid for Umlaut-Domain (IDN) HOT 1
- [BUG] Incorrect image paths in sitemap due to domain concatenate HOT 4
- UnexpectedValueException if settings.displayDuplicateImages true - Version 3.1.1 and Typo3 10 HOT 2
- Info for the manual
- Featute: Only Picture information for the current page HOT 3
- [QUESTION] is it possible to output custom (image) fields created with ext:mask? HOT 1
- Selection option for the correct license type HOT 2
- Exclude images on pages with NOINDEX in XML image sitemap
- SQL Syntax Error in sys_file_reference Query HOT 1
- PHP Warning: Undefined array key "tgm_copyright"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tgm_copyright.