Giter Site home page Giter Site logo

tgm_copyright's People

Contributors

helsner avatar hirnsturm avatar j-schmidt-magenta-mannheim avatar kanti avatar s-thierock avatar schweriner avatar sogeler avatar xippo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

tgm_copyright's Issues

Exclude images on pages with NOINDEX in XML image sitemap

Would it be possible to exclude images that are used on pages with no_index = 1 in the xml image sitemap?

If the page is hidden, images are not considered in the sitemap. That's perfect.
The no_index setting on page level has no effect.
Maybe it could be added to the query?

THX

Extension can not be loaded with composer

composer req paulbeck/tgm-copyright

reults in

[InvalidArgumentException]                                                               
 Could not find a version of package paulbeck/tgm-copyright matching your minimum-stabil  
 ity (stable). Require it with an explicit version constraint allowing its desired stabi  
 lity.   

and

composer req paulbeck/tgm-copyright:3.0.2
reults in

[InvalidArgumentException]                                                 
 Could not find package paulbeck/tgm-copyright in a version matching 3.0.2  

The Extension Repo is telling there is a version 3.0.2 but there is none at packagist.

[BUG] invalid sitemap urls on multi site instances

I'm still on the overall image sitemap topic.
To test this fully created translations, which worked fine, but now detected and issue with multi site setups as it seems.
Some of my URLs in the sitemap are like follows:
<loc>https://testdomain.ddev.sitehttps://multisite.ddev.site/cool-lover-sprizz/</loc>
Maybe someone can confirm.

As i am rewriting the functionality to a XML Provider based on the EXT:seo integrations I detected the issue as my own implementation fails when creating the link. This lets me assume, that the query is already not correct/giving out results and pages
that should not be in there originally

Making the copyright field required

The copyright field should be able to the configured as required. This setting can be placed in the EXTCONF but the useOrOverridePlaceholder of the TCA does conflict with required fields so we have to create a userFunc for creating the copyright field...

Sitemap invalid for Umlaut-Domain (IDN)

I have an "Umlaut" Domain containing "ü". Generating the image-sitemap for this domain gives me an invalid xml for Google Search Console.

Example:

IDN: my-ü-domain.de
ACE-String: xn--my--domain-ceb.de

<url>
<loc>https://www.my-&uuml;-domain.de/index.html</loc>
[...]
</url>

Can I use/configure the plugin to use ACE domain to fix this?

page structure

Please create an option to make an image-list structured by the pages where the images are located.

For example:

  • page1
    • image 1
    • image 2
    • page1.1
      • image 3
      • image 4
  • page 2
    • image 1
    • image 5

Info for the manual

The manual does not contain a reference to the setting option "displayDuplicateImages".
By the way, this is a great extension. Thanks a lot for this. 👍

UnexpectedValueException if settings.displayDuplicateImages true - Version 3.1.1 and Typo3 10

Hello,
thanks for your work!

I'm writing because I get the following error when enabling option settings.displayDuplicateImages in plugin:

Oops, an error occurred! Code: 202302241032412ded9308 - {"exception":"UnexpectedValueException: ConnectionPool->getQueryBuilderForTable() requires a connection name to be provided. in xxxx\typo3\sysext\core\Classes\Database\ConnectionPool.php:235\nStack trace:\n#0 xxxx\typo3conf\ext\tgm_copyright\Classes\Domain\Repository\CopyrightReferenceRepository.php(138): TYPO3\CMS\Core\Database\ConnectionPool->getQueryBuilderForTable('')\n#1.

Thank you in advance for addressing the issue.

Images of fluidcontent elements not shown

Hi there,

I would rather have made this a support question, but opening an issue is the only thing I could find. So please feel free to close it, if you think it's not advisable to do it here.

I have a slider built with fluidcontent. It uses a flux file field for the slider image.

I am able to change the copyright information when using file list module. But it won't get printed using the copyright plugin.

Do you have any hints on how to fix this?

Performance update

Currently all file_references are looped in the for each of the controller and checked if a copyright exists. This should be all placed within one statement inside the repository.

[BUG] Incorrect image paths in sitemap due to domain concatenate

Hi, nice extension! I especially like the image sitemap very much.

I installed the EXT and directly checked out the setup etc. in my v10 with version 3.1.0
Now i got the image sitemap.xml with includes all images listed by page.
There's an issue with the image paths though.
Currently the domain is not correctly concatenated with the path of the image.
This means i got mydomain.comfileadmin/randomfolder/image.jpg as paths.

Guess some handling is needed in the getPublicUrl() of \TGM\TgmCopyright\Domain\Model\CopyrightReference within the if condition in my case

Uncaught TYPO3 Exception

Hi,

I get an uncaught TYPO3 Exception "#1247602160: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1" after putting the plugin on a page.

TYPO3 6.2.30
tgm_copyright 0.2.0

Thanks in advance!

Greetings,
Wiebke

remove dependency to filemetadata?

Hi there!

I have a variant here where I removed the dependeny to filemetadata -
We almost always only need the copyright field from there, so the rest is just cluttering up the Backend / the Database.
Do you want a pull request for this?

Best regards, mt

composer support

adding composer support would greatly benefit this extentsion, since typo3 >= 7 extension are usually installed via composer.

xml image sitemap for extension records

It would be nice if the extension could create an xml image sitemap.
There should be a configuration option where you can set a table, a field and a value-list so that the copright extension can proof if the page with the image has meta-robots = noindex.

Improve copyright-Getter

Accessing the originalResources copyright in Fluid does not make fun. We should improve the getCopyright() function to get the originalResources copyright instantly.

Language Handling for Image sitemap?

Hi, not sure this is an issue or if I am just missing something. I have a multitree, multidomain typo3 for a client with 6 languages. We use realurl and have /en, /es, etc. for the languages. Each language has individual images named in its native language. We use tgm_copyright for just one of our 4 pagetrees.

When I look at the sitemap via DOMAIN/?type=1458065166 I see the languages mixed in the Image sitemap. For example in a german I see images from several of the other languages. If I check the source of the page, none of the other language images are there, just the correct ones for that language.

How is language handling supposed to work for this extension? I tried DOMAIN/en/?type=1458065166 and DOMAIN/?type=1458065166&L=1 but that gave totally weird results with urls from other domains / pagetrees appearing in the image sitemap.

Controller selects wrong table

I installed the extension and inserted the plug-in on a page and get the following error message in the log:

Oops, an error occurred! Code: 2016022200313183cc80b0 - {"exception":"exception 'TYPO3\CMS\Extbase\Persistence\Generic\Storage\Exception\SqlErrorException' with message 'Table 'db451379.tx_tgmcopyright_domain_model_copyright' doesn't exist' in /kunden/451379_92421/typo3/typo3_src-7.6.2/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php:878

Of course there is no tx_tgmcopyright_domain_model_copyright…

Selection option for the correct license type

Hello,

first of all kudos for the great EXT:tgm_copyright, I find it super especially since it has a function to output the images for individual pages as proof.

But I noticed that the EXT: still has a small weakness. By default, the Fluidtemplate always displays a copyright logo (©) in the FE output. However, there are numerous other license rights that are not subject to copyright, such as Public Domain or Creative Comments. A corresponding label such as © CC-BY-SA 4.0 would be wrong, however.

Is there perhaps the option to include a selection function for the correct license model in the backend and depending on this to control the FE output, for example by outputting a corresponding CSS class?

Data truncated for column 'copyright' at row 1

When you install the extension over composer and you make a db compare you will get this error.

In TYPO3 10 the copyright field already exists as text inside sys_file_metadata so a new declaration as varchar 255 will fire this error.

add expiration date

We need an extra field with the expiration date of an image.
Some manufacturers provide the images only for a limited time.
The TYPO3 System should inform in the Backend or per mail about expired images.

The plugin works, but the subtitles do not appear

Heelo,
I am not sure it's an issue.
I am using Typo3 7 LTS.
I installed the extention
I associated the Template
In the constant editor, I actived plugin.tx_tgmcopyright_main.settings.showCopyright = 1
And Nothing, no subtitle.
I am not in an other extention.

The idea should be to have : caption and below Copyright. Exact ?

What else ?
Best regards Philippe

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.