Giter Site home page Giter Site logo

sciencecommons / curate_science Goto Github PK

View Code? Open in Web Editor NEW
12.0 12.0 6.0 57.3 MB

Transparency & credibility curation products for all research stakeholders.

Home Page: https://CurateScience.org

License: MIT License

Python 5.04% CSS 15.28% JavaScript 26.86% HTML 52.68% Shell 0.03% R 0.10%

curate_science's People

Contributors

alexkyllo avatar dominik-lenda avatar eplebel avatar joeammar avatar mickaobrien avatar onejgordon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

curate_science's Issues

add Basic Help Guide section

please take the raw HTML from here:
http://curatescience.org/help-section.html

also, please replace the "ABOUT" link to the left of the avatar with a "HELP" link, which will bring the user to the basic help guide.

please also add a link to the help section within the expandable drawer , and reorder the links as follows:

Replications
About
FAQ
Help

article selector (on author page) doesn't always correctly find existing articles

steps:

  1. add 10 new articles (saving them as "article 1" (for title and authors), "article 2", etc. up to "article 10"
  2. go to a different author page
  3. click "Add Preexisting Article"
  4. type the letter 'a'
    notice that the 10 articles are correctly being listed (though it's difficult to see given what appears to be a minor UI bug within the selector dropdown)
  5. select any article and add it to the article list
  6. repeat the last two steps (steps 4 and 5) until all 10 articles are linked

notice that eventually the figure selector won't list any more available articles, even though not all of the 10 articles were linked. i'm usually able to add 6 or 7, and then the remaining 3-4 don't show up somehow (and therefore cannot be linked).

I believe this WAS working correctly before the prevent already-linked articles FIX (i.e., a9edead ), but i'm not 100% sure.

badges incorrectly displayed after removing URLs/endorsement

badges are incorrectly displayed after removing URLs/endorsement from an activated badge.

steps:

  1. add a URL to prereg, materials, data, or code badges and select a reporting standard for the reporting standards badge
  2. save article
  3. edit article, removing the URLs and selecting "None" for reporting standards
  4. save article

notice the badges are incorrectly being displayed.
Untitled222

expected behavior: they should all be "greyed out" unavailable badges.

(this seems vaguely/somewhat similar to #19 )

(proposal to) automatically link user and author page slugs on creation

this is to ensure that the following 2 requirements can be achieved (which are necessary for the crowdsourcing platform to work and grow):

  1. user names (displayed publicly and to the logged-in user themselves) need to be unique for reputational dynamics to work
  2. admins need to be able to create author pages (so that we can lure in prominent transparency mavericks by first [partially] curating their author pages and then inviting them to the platform). indeed, this is precisely what i'm doing right now for Lorne Campbell's and Daniel Lakens' author pages.

relevant discussion from #14 :
Alex:
here's a thought: What if creating an author page automatically created a linked user account, and vice versa? Then when you invite the user and they accept, their user account and author page are already linked and waiting for them, they would just need to set their password and start curating. This way, a given person's username and author slug would always match because they'd always be created at the same time, and they wouldn't need to decide between creating a new author profile vs searching for and linking one that you already created for them.

The only downside I can think of is that the users who don't need an author page would still have one, but in my mind that's OK because they could just not fill it out or link any articles to it.

I think this would work fine for both flows:

  1. You (an admin) invite someone you haven't created an author page for. You enter their e-mail and full name. A User, Author, and Invitation are simultaneously created, linked and saved. They click the link in the e-mail, choose a password, and log in, and their profile is there waiting for them.
  2. You (an admin) create an author page for someone, entering their full name. User and Author objects are simultaneously created, linked and saved. Later, you invite them, and enter their e-mail address. An Invitation is created and linked to the existing User and Author objects, and the invite e-mail is sent. They click the link in the e-mail, choose a password, and log in, and their profile is there waiting for them.

Etienne:
yes i think your proposed approach (of automatically/simultaneously creating/linking user and author page) is a good one.

however, i still think it may not cover an edge case whereby an admin creates an author page, but then that person signs up before being invited by the admin (or somehow gets invited but doesn't click the invite link). for this edge case, the user would need to be able to claim a pre-existing author page and then any (non-redundant) articles on that pre-existing author page would be merged into their newest author page.

for example, admin creates author page for "steve-smith", but doesn't invite him. later, that same person signs up under "steve-smith-2". the user then realizes that the "steve-smith" author page is his, and claims the author page. all (non-redundant) articles from pre-existing "steve-smith" author page are merged into his "steve-smith-2" author page, and the "steve-smith" author page is deactivated (or could even re-direct to "steve-smith-2" author page; but any one searching for "Steve Smith" would only be displayed the correct activated "steve-smith-2" author page.

so in summary, it appears we need the following new functionality:

  1. automatic/simultaneous creation/linking of user and author page (having same slug)
  2. allow user to claim pre-existing author page
  3. author page merge tool (merging all non-redundant articles of pre-existing author page into newest author-page)

well let me know what you think.
this of course involves a non-trivial amount of work, but the good news is that we only need the stuff in
# 1 for now and can implement # 2 and # 3 later (given that the 1st group of early beta testers won't be allowed to invite new users and non-invited users won't be able to sign-up until way later).

Edit author information button is incorrectly being displayed for non-logged in users

Edit author information button is incorrectly being displayed for non-logged in users (clicking Edit opens the Edit Author modal, though at least one can't save any changes made).

(And actually, the Edit author information button should also not be displayed for logged-in users who don't own that author page, but i have no way of testing this currently.)

e.g. https://curatescience-staging.appspot.com/app/author/etienne-lebel

outstanding known issues (mostly minor)

most minor issues (in rough order of difficulty/time to complete)

  • remove transparency badge line entirely when no badges present (e.g.; also decrease card margin-bottom from 24px to 16px, so they are all 16px (not sure how it got this way))
    Untitled-1
  • fix broken links to "replication taxonomy" PNG link within replication popup on homepage (from "https://curatescience.org/logos/replication-taxonomy-v4_small.png" to "https://curatescience.org/sitestatic/legacy/logos/replication-taxonomy-v4_small.png")
    Untitled-3
  • add "Google Scholar" in citation title (i.e., "Article has been cited 20 times (as of December 15, 2018; Google Scholar)")
  • add Richard Shiffrin to advisory board on about page (to the right of Mark Brandt; headshot image, link headshot image to http://shiffrin.cogs.indiana.edu/, Richard Shiffrin, Indiana University(italicized).
    • also update Wolf Vanpaemel's role from "Conceptual/Funding Advisor" to "Conceptual Advisor" and add Mike Morrison's missing affiliation ("Michigan State University"(italicized))
  • for DOI input text box, trim/remove the prefix "https://dx.doi.org/" if entered by the user (e.g., "https://dx.doi.org/10.1016/j.jesp.2013.10.005" should be trimmed to "10.1016/j.jesp.2013.10.005" (because we add the prefix automatically in the UI))
  • improved order of impact metrics: citations, downloads, and views rather than views, downloads, & citations (this means specifically: for PDFs (citations, downloads, & views) and preprints (downloads & views)
  • 2 typos in AT drop-down: Re[a]nalysis – Meta-Analysis and Re[a]nalysis Meta-Research (missing 'a's)
  • for “reanalysis – meta-research” article type, hide reporting standard badge (in article list & edit article modal (because it's not applicable))
  • add supported image file types within add article component (i.e., .jpg, .gif, and .png)
  • add info icon w/ popup on hover (to the right of "ADD PREEXISTING ARTICLE" button) explaining the logic of linking pre-existing articles to one's author page: "Link an article to your author page that is already in our database (for example, an article that has already been added by one of your co-authors)." Also update text and icon within button as in mockup below (from "ADD PREEXISTING ARTICLE" to "LINK EXISTING ARTICLE"; link icon instead of add icon). (beta user feedback)
    link-existing-article-info-mockup
  • horizontally center the navbar so that its width is not 100% (which looks bad on large displays (as explained here)
  • integer input box controls (i.e., down-arrow) shouldn’t allow negative values
  • implement CTRL+ S keyboard shortcut within New/Edit article editor modal to SAVE changes!
  • fix transparency badge popup issues (issue #35; i.e., incorrectly auto-closes after about 1 sec. & hovering over a neighbor badge doesn't activate its popup)

slightly more involved MINOR issues

  • improve article selector so one can see the entire title (by trimming authors text beyond 25 characters & by widening the autoCompleteReactSelect component itself from 428px to 700px )
  • yield error message if non-supported file type is uploaded (i.e., “Image file type not supported. Only .jpg, .gif, and .png image file types are currently supported.”)
  • remove delete figure tooltip for non-admin users (given that they don’t have permission to complete this action)
  • within Article selector component, HOME & END keys don’t work (useful when one wants to try a diff. key word)
  • check duplicate article after leaving Title and DOI input boxes (rather than on Save; & display small button so they can link it to their author page)
  • UNLINKING articles: add snack bar message confirming the unlinking with clickable “UNDO” (to undo the action)
  • DELETING articles (ADMIN ONLY): add snack bar message confirming the deletion with clickable “UNDO” (to undo the action)
  • secondary transparency previews (so user knows whether worth expanding; beta user feedback)
    secondary-transp-previews
  • mobile friendly (at least improve it so that it’s closer to specs, i.e., closer to mobile-friendliness of my alpha author page)

signup/login pages issues

  • convert to React pages
  • after successful password reset, redirect to home page
  • remove "Are you sure you want to sign out" warning page
  • when user logs out in different tab (or browser cache is cleared), actions requiring being logged in don't work (expected behavior: should automatically bring user to log-in screen).

admin-related issues

  • surface error if admin tries to invite user w/ pre-activated author page already linked to another user (see github comment)
  • improved admin dashboard (user list & basic details; new author & invite buttons; see paper mockup)
    admin-dashboard

missing/incomplete components

various components still missing/incomplete (only MVP-critical issues listed):

on article cards within article lists (example article lists: LeBel, Campbell):

  • transparency badges below journal name (rather than below authors)
  • transparency badge popups (appear above badge; auto-close so can see popup of next/neighbor badge; display linked link icon rather than URL)
  • (bonus) transparency badges not being rendered for "Commentary" and "Conceptual" article types
  • display # of replications within replication label
  • replication details on Replication label hover
  • commentaries label (including # of commentaries)
  • commentaries details on Commentaries label hover
  • view key figures via fancyBox plugin

Edit Article modal window:

  • replication details form inputs (see here)

more minor outstanding issues will be posted in a separate "low priority" (non-MVP) issue.

author page article list/edit functionalities

specs for author page article list and edit functionalities:
author-page-edit-functionalities

when creating a new author page, everything will be blank except the "Edit info" button within the "Author information" section and the "Add article" and "Link preexisting article" buttons.

  • "Add article" button opens the "New/Edit article info" modal window with everything empty.

  • "Edit article" button opens the "New/Edit article info" modal window with pre-existing info loaded.

  • Clicking "Link preexisting article" will reveal the "Find preexisting article" search box (the same one as already implemented to link an original study to a replication study (https://curatescience-staging.appspot.com/new/article/8/edit)), so that an article already in the DB can be linked to a specific author page (whether that article is linked to a different author page or not).

  • clicking "Unlink" will unlink that article from that author's page (leaving it linked to any other author pages; and also leaving it in the DB, even if it's not yet linked to any other author pages).

  • Added/linked articles will be displayed using the HTML and CSS that i used to generate the author pages of 3 prominent (open-science maverick) researchers: lorne.campbell (use this one as it covers all features), daniel.lakens, and julia.rohrer (which are actually a slightly scaled-back version of my own etienne.lebel author page). the only exception being the use of proper tooltips to display badge, replication, and commentary details on hover (note that these are interactive/contain clickable content), instead of my hacky span solution. UPDATE FEB 25: if this part of the UI still hasn't been implemented, please use improved labels and full-text buttons from etienne.lebel's author page

  • only admins will be able to delete an article, which will unlink it from all author pages and destroy it within the DB. this works because there's no use case for an author to want to delete -- rather than unlink -- an article. if an error is made (wrong title, wrong transparency URLs, even wrong DOI), then that information can be edited. hence, deleting an article should almost never need to happen, and if it does, only admins should be able to do this. (UPDATE: one rare case i just thought of for an admin to need to delete an article is for duplicate unpublished or "in press" articles given that these won't have a DOI and our initial UI won't be checking for duplicate titles (though we could implement this later)).

(eventually, we will implement "Quick add" functionalities (e.g., drag-and-drop DOI or PDF or PDF URL onto "Add article" button, which will automatically populate basic article metadata fields); we will also implement 2 ways to add batches of articles: "Import from Google Scholar" and "Import from ORCID ID account")

stylistic/aesthetic issues

major stylistic/aesthetic issues (MVP-critical only):

Article list:

  • proper wrapping of full-text buttons (in own floating-right div, so that article title wraps properly)
  • larger full-text buttons
  • correct max-width for cards (~530px; crucial for readability of titles and abstracts)
  • larger (down-arrow) expand button (should be at least 32 x 32px)
  • icons within buttons should precede text (as in specs and standard practice)
  • peer review information all on the same (rather than separate) line
  • author_contributions, competing_interests, and funding_sources should be trimmed beyond ~85 characters (rather than 500)

Edit Article modal window:

  • narrower padding and smaller fonts (to fit more content without vertical scrolling)
  • narrower max-widths for most text fields (and/or overall div) for improved readability

more minor aesthetic issues will be posted in a separate non-MVP issue.

form loading/saving frontend latency and responsiveness issues

though the server side latency issue was noticeably improved by fixing #9 , several more specific frontend latency issues still remain:

some operations still take more than ~1.5 seconds for anything to happen on screen. for example:

  • clicking "Add Article" takes almost 2 seconds to open the New Article modal window;
  • linking a pre-existing article to an author page takes about ~3 seconds for anything to happen after clicking on the found article within the react-select component
  • when editing an article, it takes ~1.5 second for the existing article info to load (and article information from previous article is shown immediately, which is also confusing)

hopefully your "debounce-input" strategy (as noted in your TODO list #10 (comment) ; Form update performance (latency, consider https://www.npmjs.com/package/react-debounce-input)) will help.

of course i'm not expecting enterprise-level performance (given our limited budget), but i'm hoping we can achieve about a 1-second delay maximum for most operations.

also, responsive feedback is missing for most (slow) operations. for instance, it would be good to add 3 animated dots (like within the react-select component), whenever an action is executed that takes longer than 1 second (e.g., displayed within the clicked button or otherwise).
untitled

homepage navbar changes

homepage-navbar-changes

actually, let's just update the navbar for now (i'll just keep occasionally adding featured articles manually). once the main author page functionalities are implemented, we can then updated the homepage to display recent articles from the DB (rather than pulling from the HTML).

  • "Replications" link (http://curatescience.org/replications.html) moved within the left-opening drawer
  • logged-in users can click "Create author page" to create their own article list (this becomes "My author page" once an author page exists, which will bring the user to their author page/article list)

admin users will have the following additional capacities:

  • to create additional new author pages
  • add new articles not yet associated with an author page
  • invite new users so that they can create their own author page. see #14 for details.

articles not correctly being linked to an author

it appears that when creating new articles or linking them to an author, some of the articles do not get correctly linked to the author.

scenario 1:

  • i was adding new articles to lorne campbell's production author page via "Add article".
  • as i was adding them, they were correctly appearing at the top of his author page
  • after having added all of his 22 articles, i loaded his author page in Firefox to make sure that i could view all of his articles publicly (without being logged in).

only 13 articles were listed.

but when i checked the admin page, all 22 articles are in fact listed.

scenario 2:

  • to see if i could reproduce this, i went to my author page, and linked 11 articles i had just created on top of the 4 articles already on my author page.
  • again, as i was individually linking them, they correctly appeared at the top of my author page
  • i then went to Firefox to load my author page,

and only 5 articles were listed.

i went back and refreshed my author page (within my logged-in session), and sure enough now only (the same) 5 articles appeared.

hence, it appears articles sometimes aren't being correctly linked to an author (when being created or linked), but i have no idea why it's only happening sometimes.

this is kind of a show stopper, and needs to be fixed for me to be able to continue seeding the production DB.

UPDATE: the problem seems to only emerge when creating/linking articles in succession. if i link an article, and then refresh the page, and then link another article, and then refresh the page, the articles do seem to be linked correctly. however, if i try to link articles in succession without refreshing the page in between, then only some get linked correctly.

~2 second latency issue on staging

the staging website ( https://curatescience-staging.appspot.com/ and https://curatescience-staging.appspot.com/new/recent ) is substantially slower than the production website (https://curate-science-216207.appspot.com/). e.g., loading homepage/viewing article takes a full 3-4 seconds whereas on the production website it's almost instantaneous.

jeremy input: it seems to take a good 3-4 seconds longer to load an article page (or to load an article's "update" page) compared to production, and it seems to stay this way even after several interactions (potentially ruling out Jeremy's "warm up" hypothesis).

Alex responses:
Testing it out, I also noticed that staging takes about 3000ms per request while prod takes only about 400ms. They're not configured any differently in App Engine, and the two databases are on the same VM, so there must be something about how the database are configured that's causing different SQL query latency. I'll keep digging...

The individual SQL statements being issued to the database are the same between prod and staging, so it is not due to any code change in the Django app generating slower queries on staging. And when I run the queries directly on the server, they take a similar amount of time on both databases. The databases have identical schemas and almost identical data in them so now I'm leaning toward it being something in GAE, but I'm not sure what yet. I basically didn't configure anything in GAE so I'm not sure what settings there are that affect app performance. That will require more research.

I can confirm that it's also not the indexes--staging has the exact same indexes as prod.

What about just recreating both production and staging websites anew and seeing if that resolves the issue?

outstanding issues for initial beta release

Article List/Author Page

  • update website-wide icon (new snail logo as on alpha page; link to icon )
  • add missing article type label borders for “reanalysis – reprod/robustness”, “reanalysis – meta-analysis”, and “reanalysis – meta-research” article types
  • move article type labels between journal name and transparency badges (see screenshot below; which requires updating article TITLE style to "margin-top: 0px; padding-top: 2px;" and transparency div style to "margin-bottom: 5px;")
    AT-below-journal-name
  • make publication year bold (incl. parentheses: i.e., "(2019)"; as in screenshot above).
  • impact icons stylistic tweaks (view icon: "font-size: 14px; margin-bottom: -2px"; download: "font-size: 13px; margin-bottom: -1px"; citation: "font-size: 19px; margin-bottom: -5px")
  • replication details popup: for replication definition text: add margin-top: 15px, use correct grey color (#808080), and fix incorrect line break between ‘is’ and ‘close’
  • use correct prereg+ badge (we won't use badge w/out + given that we have prereg type text describing the preregistration type (i.e., whether study+ analyses vs. study only was preregistered))
  • add prereg type text in prereg popup based on preregistration type (“Preregistered study design + analyses”, “Preregistered study design” , and “Peer-reviewed preregistered study design + analyses” for preg+, prereg, and Registered Report preregistration types, respectively); also increase size of content provider icon to match size of external link icon (see screenshot below):
    prereg-type-text
  • add missing Registered Report label (which appears to the right of article type label; see first screenshot above), based on prereg type radio button value
  • add titles for non-popup article type labels (i.e., all labels except replication article type label):
    • Conceptual: "Article involves a conceptual/theoretical contribution"
    • Reanalysis - Reproducibility/Robustness: "Article reports a reproducibility/robustness reanalysis of a previously published result"
    • Reanalysis - Metaanalysis: "Article reports a (traditional) meta-analysis of a target effect/phenomenon"
    • Reanalysis - Meta-research: "Article reports a reanalysis of results from previously published studies (meta-research)"
    • Commentary: "Article is a commentary on previous research"
    • Original: "Article reports original empirical observations (not directly comparable to previous research"
  • update Article selector placeholder text (to “Search articles by title or author last name”)
  • fix transparency badge popup issues (issue #35)
  • horizontally center the navbar so that its width is not 100% (which looks bad on large displays (as explained here)
  • move action buttons outside of article card (to the right, as explained here)
  • add missing link icon (so users can share/link to a specific article card; as on alpha page, e.g.)

Article EDITOR

  • display only article type-relevant badge input boxes (matching what's already implemented for displaying different badges for different article types):
    • Reanalysis - Reproducibility/Robustness: hide "Public Study Materials URL" and "Reporting Standards" input boxes
    • Reanalysis - Metaanalysis & Reanalysis - Meta-research: hide "public Study Materials URL" input box
  • update text "Protocol Type" to "Preregistration Type"
  • fix impact metrics “as of Date” (it should be date of last edit for specific impact metric field; currently, it seems to be the date of last article edit (OR seems to be the correct date if 2 impact metric fields are updated)
  • within "ADD A FIGURE..." component, remove “ADD FIGURE” and “Cancel” buttons given that images automatically upload upon selection
  • fix issue whereby one can’t remove impact metric if full-text link has been entered (it says must enter integer, but if enter 0, one can proceed; steps: 1. enter full-text URL (for PDF, HTML, or Preprint), 2. enter an impact value (for any field) and save, 3. now go back and remove impact metric and save. Notice the error message.)
  • prevent invalid URLs from being inputted in edit author modal (issue #27)
  • multiple file key figure upload

Other:

  • focus cursor in first text box in various modals/components: i.e., on"New/Edit Article" modal (focus cursor in article title text box), "Edit Author" modal (focus cursor in Name field), and in text box of Article selector component (for "New/Edit Article" and "Edit Author" modals, if text box is non-empty, select the text)
  • reduce height of navbar to 56px (by decreasing min-height: 64px to 56px;)
  • raise error if admin tries to invite a user with pre-activated author page that is already linked to another user account (see github comment)
  • update content/fix styles of About, FAQ, and People sections & footer (including Privacy and Terms of Service); new and updated content as follows:
    • Updated "About" section: take from http://curatescience.org/#about (remember to update background-color of the About section to White instead of gray).
    • Updated "People" section: take from http://curatescience.org/#people (and it's fine to include "People" within the About section, as you've already done.)
    • Updated "FAQ" section: take from http://curatescience.org/#FAQ (again remember to update background-color to white instead of gray
    • Add "Newsletter" section: take from http://curatescience.org/#newsletter and please add link to "Newsletter" in the left-opening side drawer (so links will be "Replications", "About", "FAQ", "Newsletter", and "Help")
    • Update footer to what is on alpha homepage (just below http://curatescience.org/#newsletter)
    • For "Terms of Service" and "Privacy Policy", link to Privacy page you already have, and display the following (temporary) text under two subsections:
      • Terms of Service: "As a condition of use of this website, you promise (1) to be honest, (2) to curate scientific information as accurately and impartially as possible, and (3) to not be a jerk.
      • Privacy Policy: "We will never share or sell your personal information with anyone. Ever."

non-admin users can edit and delete other authors' articles

this actually involves 3 different problems (each of which used to work very recently):

  1. non-admin users should not be allowed to delete anyone's articles, including their own
  2. non-admin users should not be allowed to edit other authors' articles
  3. non-logged in users shouldn't see the Edit, Unlink, & Delete action buttons on card hover

i don't think these are due to a transition issue (related to user/author model changes), though i'm not 100% sure on this (but perhaps some of these may have started once card actions were moved to outside of card?)

Error running tests on new repo setup

Followed instructions in README and successfully have server running.

python manage.py test
Creating test database for alias 'default'...
**Got an error creating the test database: permission denied to create database**

I tried creating the test database manually but that hasn't helped. Probably a simple issue.

invite user functionality for admins

admins need to be able to invite new users so that they can create their own author page.

perhaps for now, clicking "Invite new user" (from user menu bar, see mockup in #13) can open a modal window with email address and name text fields and a "Send Invitation" button. this will send an email to the user with a signup invitation link.

when clicked, the user will go to signup page, which will have their email and name pre-populated, and password field (which user will have to copy-and-paste from the email?).

clicking "Sign up" will then create the new user account, log-in the user, and bring them to the homepage in a logged-in state (where they can then click "Create author page".

Alex comments

E-mail address is the username, but I do need to implement a feature for the ability for admins to send invites. Looks like there are existing packages for this, so it shouldn't be much work. And since only admins will have invite permissions, there's no need for an invite quota. But if you decide you want to give authors the ability to send invites with a quota, let me know.

Etienne response

ok sounds good. and indeed authors should have an invite quota, which initially will be set to 0. only once the author page is tested and improved based on a small group of users (~15-20), will we want to give 2-3 invites to each user. but i'm not sure if you want to implement this now, or just add it later.

2 required fields issues in Edit Article modal

1st issue:

  • the authors field needs to be a required field as per the specs
    (i believe article title and publication year are currently required fields, even though errors related to missing values for these required fields aren't yet communicated to the user).

2nd issue:

  • checking "in press" does not correctly count the field as being filled.
    steps:
  1. click "Add Article"
  2. enter article title, delete default "2019" year, and check "In press" checkbox
  3. click Save
    notice that Saving the article is (incorrectly) not allowed

additional info: if you uncheck the "In press" checkbox, re-enter a publication year, re-check the "in press" checkbox, then somehow the article does save.

also please add an asterisk * to the right of each of the required fields box label (title, authors, and year) and add the text "* indicates required field" at the bottom of the modal window (as per specs).

adding article with prereg URL w/out specifying prereg type breaks author page

steps:

  1. add new article (add title & authors)
  2. enter URL for prereg protocol URL input box, and click Save

notice author page doesn't load and following error is given:

Uncaught TypeError: Cannot read property 'label_detail' of undefined at TransparencyBadge.render_feature (webpack:///./src/components/TransparencyBadge.jsx?:144)

solution: once the "Prereg protocol URL" input box becomes non-empty, automatically select the first radio button ("Preregistered study design + analysis").

(given that this will be the correct prereg type in >95% of cases, and so solves the problem and increases curation efficiency!)

final minor tweaks to Edit Article page (before inviting 3 early beta testers)

in the order that they appear:

  • for AUTHORS input box, update placeholder text to "e.g., SS Smith, JJ Jones, & KK Pratt"

for REPLICATION input boxes:

  • for NUMBER OF REPS input box, remove the "2" placeholder text

  • for ORIGINAL STUDY input box, update placeholder text to "e.g., SS Smith et al. (1989) Study 2"

  • for TARGET EFFECT(S) input box, update place holder text to "e.g., playboy effect"

  • for all 6 impact metric input boxes, remove the "2" placeholder text

  • for ACTION EDITOR input box, update placeholder text to "e.g., SS Smith"

  • for PEER REVIEWERS input box, update placeholder text to "e.g., SS Smith, Anonymous reviewer 2 (separate using ',')"

  • for OPEN PEER REVIEWER URL, update placeholder text to "http://..." (like all the other ones)

for commentaries:

  • update button text to "ADD COMMENTARY" (instead of "ADD ADDITIONAL COMMENTARY"). original specs had "ADDITIONAL" because AUTHORS/PUBLICATION YEAR and COMMENTARY URL input boxes for a 1st commentary were displayed by default (hiding these until "ADD COMMENTARY" is clicked i guess is OK given that it declutters page a bit).
  • for AUTHORS/PUBLICATION YEAR input box, update placeholder text to "e.g., Smith & Smith (2019)"
  • for "COMMENTARY URL" input box, update placeholder text to "http://..." (like all the other ones)

article list stylistic issues (medium priority)

medium priority article list stylistic issues to be fixed for MVP (early beta testers):

  • peer review information all on the same (rather than separate) line
  • author_contributions, competing_interests, and funding_sources should be trimmed beyond ~85 characters (rather than 500)
  • larger (down-arrow) expand button (should be at least 32 x 32px)

moved from #23

crucial article list stylistic issues (high priority)

high priority article list stylistic issues to be fixed for MVP (early beta testers):

  • icons within buttons should precede text (as in specs and standard practice)
  • proper wrapping of full-text buttons (in own floating-right div, so that article title wraps properly)
  • correct max-width for cards (~530px; crucial for readability of titles and abstracts)
  • larger full-text buttons

moved from #23

non-admin users can't cancel out of new article modal after waiting longer than ~1 second

steps:

  1. as non-admin user, click "Add article"
  2. wait ~1 second
  3. click cancel
    notice nothing happens and one cannot cancel out of modal window (must reload the page to continue, which will bring you back to author page)

additional info:

  • can cancel right away, but not after brief moment of about ~1 second
  • it happens whether text is entered or not
  • it does not happen if editing pre-existing article (i.e., edit pre-existing article, wait more than ~1 second, notice can cancel out of modal)

somehow this only happens for non-admin users, so i suspect this is related to setting articles as live/non-live.

article added by admin on an author page incorrectly becomes linked to admin's own author page

steps:

  1. logged in as an admin user, add an article to an author page (other than one's own)
  2. go to your own author page

notice how the article just added (on a different author page) now incorrectly appears on one's own author page (presumably because it has been incorrectly linked to it).

i'm not sure how long this has been an issue, because i only yesterday managed to link an author page to my admin account ([email protected]), but it definitely wasn't happening before i'd associated an author page to my admin account.

(but it's kind of a crucial bug given that i need to curate several additional author pages and don't want all of these articles to become incorrectly linked to my author page).

non-admin users cannot delete figure

non-admin users cannot delete added figures. attempting to do so yields server responded with a status of 403 ()

this was definitely working before, but i'm not sure when it stopped working.

admin users still can delete added figures

Article editor modal window

specs for new/edit article info modal window for within-card editing of article information or for creating a new article (all fields blank in this case):
new_edit-article-info

no deep-linking, no auto-complete fields. the only "smart field" is the DOI field whereby it should give an error (on save) if DOI is already in the DB

  • for "Replication" article type, "Replication details" fields will be visible (for all other article types, this section will be empty)

  • clicking "Add figure" button will open a "browse for file" window and let users select the figures/table images (multiple selection allowed; a URL can also be inputted as is standard for this type of dialog window). the image(s) will then be uploaded, compressed (i've been using https://tinypng.com/), and thumbnailed ("Add figure" button remaining to the right of thumbnails as is currently implemented). the image should grow vertically within a 3-column div (given there will be < 6 figures/tables 90% of the time).

this should be implemented exactly as is (given that this will currently mostly be for internal use only; we can improve the UI/UX later). please note that the font and padding should be very small/compact so that all fields can be visible on a large desktop screen (crucial to maximize data entry/curation efficiency).

fix transparency badge popup issues

2 issues still remain:

  1. hovering over the badge activates the popup, but then it incorrectly auto-closes after about 1 second (at which time the action buttons [Edit, Unlink, Delete] and impact metrics appear; so the issue is probably related to the action buttons on hover functionality)
  2. hovering over a contiguous badge doesn't activate the neighboring badge's popup (this 2nd issue may actually just be a symptom of the 1st issue).

copied over from #22

"In press" checkmark no longer working

saving an article as "In press" incorrectly saves it as being published in default (2019) or inputted year.

if you edit the article and delete the default 2019 (or any other entered year) and try to save, nothing happens (presumably because an error is thrown).

i believe this previously worked (but can't remember when).

steps.

  1. create a new article with title, authors, and click "In press"
  2. save article
    Notice it says 2019
  3. now click Edit article
  4. remove 2019 and click Save
    Notice nothing happens

article incorrectly re-appears within article list if it is deleted in succession with another article

deleting two articles in succession deletes each successfully, but somehow the 1st article deleted then incorrectly re-appears within the article list;

steps:

  1. delete article 1, then delete article 2

notice article 1 disappears, then article 2 disappears, but then article 1 re-appears.

trying to delete article 1 then doesn't do anything because it's already been deleted. if the page is reloaded the article (correctly) doesn't appear.

if one waits at least 2 seconds in between deleting articles, the issue doesn't seem to arise.

perhaps a parallel bug to #31

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.