sclu1034/lua-libpulse-glib

Mirror of https://git.sclu1034.dev/lucas/lua-libpulse-glib

lua-libpulse-glib's Issues

Subscriptions don't work because `pa_context_subscribe` isn't called

I think it makes sense to call it in context_state_callback with PA_SUBSCRIPTION_MASK_ALL when the state is ready.

On Lua 5.3 at least some callbacks seem to be getting an extra argument

Thanks for the library! PipeWire proves to be incredibly hard to work with for something simple like programmatically changing the volume of the current sink, so your library is a savior (assuming I'll end up at the goal, of course - I just started experimenting).

Couldn't install the library with luarocks, had to compile manually.

Callbacks for both ctx:connect and ctx:get_sinks now receive something extra as the first argument, which at least in my case is always nil. So I had to change the code from the README to this (note the underscores):

ctx:connect(nil, function(_, state)
    if state == 4 then
        print("Connection is ready")
        ctx:get_sinks(function(_, sinks)
            ppretty.dump(sinks)
            loop:quit()
        end)
    end
end)

`get_sink_info` doesn't work for strings

Same with get_sink_info_by_name, getting bad argument #1 to 'get_sink_info_by_name' (function expected, got string).

I think the line simple_callback_data* data = prepare_lua_callback(L, 2); should use 3 instead of 2.

Impossible to use from Awesome WM due to the `context_new` function implementation being overriden by `libselinux.so.1`

$ lua
Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> require('lua_libpulse_glib').new():context('a')
pulseaudio.context: 0x55ddb22b3a38
>

But:

LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libselinux.so.1 lua
Lua 5.3.6  Copyright (C) 1994-2020 Lua.org, PUC-Rio
> require('lua_libpulse_glib').new():context('a')
>

Seems like this function overrides the one from this library: https://www.mankier.com/3/context_new.

The fix would be to replace #define LUA_MOD_EXPORT extern (extern on defined functions doesn't make sense anyway, AFAIK) with #define LUA_MOD_EXPORT __attribute__((visibility("default"))) and to add -fvisibility=hidden to CFLAGS in the Makefile.