scottohara/eslint-config-oharagroup

O'Hara Group JS style guide

eslint-config-oharagroup's Issues

Typescript incompatible rules

Tracking references:

1. eslint/typescript-eslint-parser#77
2. https://github.com/nzakas/eslint-plugin-typescript/issues/101

When using shorthand constructor property assignment, eslint complains about

• no-useless-constructor
• no-empty-function
• no-unused-vars (even though the property is referenced elsewhere)

no-type-alias error

Tracking reference: bradzacher/eslint-plugin-typescript#137

When typescript/no-type-alias is enabled, throws the following error:

TypeError: Cannot read property '0' of undefined
   at getMessage (/foobar/node_modules/eslint-plugin-typescript/lib/rules/no-type-alias.js:194:26)
   ...

Temporarily disabled until the linked PR is merged.

space-infix-ops fails for mapped type declarations

Tracking references:

1. eslint/typescript-eslint-parser#449
2. eslint/typescript-eslint-parser#486
3. eslint/eslint#10922
4. eslint/eslint#10923
5. JamesHenry/typescript-estree#17

Affects the following types in https://github.com/scottohara/tvmanager:

• global.d.ts: PublicInterface<T>
• framework/spinningwheel/index.d.ts: SlotData<T>

Workaround is to add spaces (e.g. SlotData < T >).

Consider disabling @typescript-eslint/typedef

This rule enforces types even when the type is able to be inferred.

As we use noImplicitAny, the compiler will warn if something can't be inferred, so there is no danger introduced by not using this rule.

Removing unnecessary type annotations (and their imports) should clean up the code.

One reason we used the rule was to enforce consistency (always type), since there is no equivalent opposite (only type when necessary). So when removing unnecessary type annotations there is no way to tell if we've removed them all.