Giter Site home page Giter Site logo

popup-zen's People

Contributors

scottopolis avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

popup-zen's Issues

Support URLs as call-to-action destination

I would love to use the plugin to promote content that doesn't require email signup. So instead of opening the email/name input fields, the "Learn More" button would actually take users to a different URL.

link-instead

This requires the following changes:

  • Make "Fields" setting for each popup optional.
  • Introduce a new URL destination field.

Would this be something valuable to the users? Happy to open a pull request with the suggested implementation.

Hidden Popup Still Clickable

When a visitor closes a popup, the pzen-expanded class is removed, and it defaults to these styles:

.popup-zen-box {
	opacity: 0;
	position: fixed;
	z-index: 99997;
	width: 100%;
	max-width: 325px;
	overflow: auto;
	...
}

Unfortunately, you can still interact with an element that has opacity: 0. I noticed it because our links are clickable even after the popup has been closed.

Screen Shot 2019-05-28 at 4 11 57 PM

The box would need to have a display: none applied, moved offscreen, or removed from the DOM entirely.

Also, if someone closes the popup and then refreshes the screen, the popup is still hidden (opacity: 0), but it is present in the DOM. I think a better solution would be to check for the "hide" cookie before outputting the markup.

--

I'm happy to help with a fix for this if you're open to pull requests, but would need to know if there's any reason you're currently going with the current method. I.e., Would a popup that has been closed ever be activated at a later time in the same session (and therefore need the markup to be available)?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.