scottwernervt/ember-cli-group-by

An Ember.js helper for grouping objects by async properties.

ember-cli-group-by's Issues

Missing (default) category does not work for async relationships.

Reduce fails if nested async belongsTo property is undefined:

const itemGroup = paths.reduce((previous, path) => {
  const previousItem = RSVP.resolve(previous);
  return previousItem.then(nestedItem => get(nestedItem, path));
}, item);

VM250 ember.debug.js:18008 Assertion Failed: 
 Cannot call get with 'name' on an undefined object.

Discovered while creating ember-twiddle demo.

TravisCI: Remove deprecated `sudo: false` option

See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration

Tests fail for ember-lts-2.4 and ember-lts-2.8 with contentisFulfilled and isFulfilled

All integration tests are failing for Ember 2.4 and 2.8 LTS:

not ok 5 Chrome 58.0 - helper:group-by-path: It groups by given single path
    ---
        actual: >
            contentisFulfilled
        expected: >
            AabBcd
        stack: >
                at http://localhost:7357/assets/tests.js:249:14
                at tryCatch (http://localhost:7357/assets/vendor.js:70691:14)
                at invokeCallback (http://localhost:7357/assets/vendor.js:70706:15)
                at publish (http://localhost:7357/assets/vendor.js:70674:9)
                at http://localhost:7357/assets/vendor.js:48982:7
                at invoke (http://localhost:7357/assets/vendor.js:17247:16)
        message: >
            AabBcd is the right order
        Log: |
    ...

not ok 5 Chrome 58.0 - helper:group-by-path: It groups by given single path
    ---
        actual: >
            isFulfilled
        expected: >
            AabBcd
        stack: >
                at http://localhost:7357/assets/tests.js:243:14
                at tryCatch (http://localhost:7357/assets/vendor.js:68307:14)
                at invokeCallback (http://localhost:7357/assets/vendor.js:68322:15)
                at publish (http://localhost:7357/assets/vendor.js:68290:9)
                at http://localhost:7357/assets/vendor.js:57770:16
                at invoke (http://localhost:7357/assets/vendor.js:18343:16)
        message: >
            AabBcd is the right order
        Log: |
    ...

Private nested computed properties do not fire when changes made in array.

Bug
Test It watches for nested changes is failing as the helper does recompute when a nested property in the array is changed. This is due to _nestedX computed properties not firing because they are never called.

Unconsumed Computed Properties Do Not Trigger Observers

If you never get() a computed property, its observers will not fire even if its dependent keys change. You can think of the value changing from one unknown value to another.

https://guides.emberjs.com/v2.13.0/object-model/observers

Temp Solution
Call each computed property in recompute function.

Solution
Is there a better way to handle fire observers and computed properties for tracking nested changes?