Default chords no longer work

[scribbletune]

Default chords no longer work

[Zunawe]

No problem! I've been having a lot of fun with this. Youtube recommended your SFNode presentation a few days ago and I've been sharing that around a bit. Keep it up!

[walmik]

Sorry for the confusion. scribble.modes is not a method. It s a property. Can you try console.log(scribble.modes) instead and see if you are getting the list of modes/scales?

There is a method called scribble.mode() - mode not modes. Maybe that s the one you wanted?

[Zunawe]

Oh whoops. That's a typo. I meant scribble.mode(). I tested with scribble.mode().

On that note though, the documentation does say "You can list the available modes by invoking the modes method."

[walmik]

I see! Good catch... So other than the documentation, is there an issue in invoking scribble.mode() or scribble.modes?

[walmik]

BTW, scribble.mode() should be called with the root and the mode you want at least. For e.g. scribble.mode('c', 'ionian'). However, as per what we pushed last night, v0.10.0, we can directly do scribble.mode('c ionian') OR scribble.scale('c major')

[Zunawe]

scribble.mode() works fine when you explicitly specify the root and mode. However, looking before 1a6cb73,

scribble.mode(undefined, undefined, undefined)

returns a C Major scale on octave 3. The documentation indicates this use:

// Create a clip that plays the middle C
var cMajor = scribble.scale();  // [ 'c3', 'd3', 'e3', 'f3', 'g3', 'a3', 'b3', 'c4' ]

This code (which sets those defaults) has no effect because if root or mode are undefined, we'll get a TypeError trying to call match() or an AssertionError checking that mode exists.

And maybe that should be removed so that the user has to be explicit always, but then there should be a more explicit assertion with the arguments, and it should be removed from the documentation.

Otherwise, moving it to the top of the function should allow for those default values again. (Also the default is octave 4 now. To be super nitpicky and annoying.)

[walmik]

Ah I see! Last night's push caused this. I ll fix this such that mode() without any params continues to return the C Major scale.

[walmik]

Thank you so much for going through the code and the commits to unearth this!