Comments (6)
Hi Göran!
It appears Peter Jansen's latest changes to the CTCE driver that I merged may have reverted my earlier fix.
I need to do some research to see if maybe I can figure out how it broke and how to fix it (which may require me to contact Peter for help).
In the mean time, could you please do us a favor to help us please?
I would like to see a CCW trace on devices E24 and E25 for both commit 9269d74 (without Peter's changes) and commit 6359717 (with Peter's changes).
Make sure you do a CCW trace (t+e24
, t+e25
) when you run your test on each version. The goal here is to compare how each behaves, both with and without Peter's changes, so I need to see the CCW trace for both test runs (both with and without Peter's changes).
Thanks!
from hyperion.
from hyperion.
Oops, sorry for sending the same e-mail twice.
from hyperion.
Oops, sorry for sending the same e-mail twice.
No problem. As the repository owner, I can delete any comment I want.
Your duplicate comment has been deleted! Problem solved! :)
FYI: I would personally prefer that everyone not use email when responding/replying to an issue, and instead use GitHub's web based user interface.
Yes, I realize it may be faster and easier to respond via email and slightly more bothersome to use GitHub's web interface instead, but here's the problem: GitHub does not allow me to edit email based replies using markdown (styling). It only allow markdown for comments entered via their web based user interface.
Forgive me, but oftentimes the comments added by others are not well formatted, and I prefer to be able to edit them so they are easier to read and understand (adding italics, inline code, etc) . I cannot do that when you reply via email.
You can continue to reply via email if you want. That's okay. I'm not asking or demanding that you to change your behavior!
I'm simply letting you know about my own personal preference, that's all.
Whether or not you feel my personal preference is important enough to you to change your behavior is entirely up to you. ;-)
from hyperion.
... but then I realized that the extra logic Fish introduced around “ctce_haltorclear” in the CTCE_Send routine would cause problems on the “send” side. [...]
That was going to be my second guess! ;-)
I wasn't sure whether it was my attempt to the fix the HaltOrClear logic in the various communication device handlers (LCS, CTCI, CTCE and PTP) or whether it was something you did in your original merge request (which was based on a version of my SDL Hyperion without my "fix"). I was hoping Göran could do some tests for us to determine which it was. (I am unable to test CTCE myself.)
I only suspected your code since my code is always perfect and 100% bug free. Only other people make mistakes. I never do. ;-)
</sarcasm>
Anyway, THANK YOU Peter, for finding and fixing this bug so quickly!
And please accept my apology for temporarily breaking your truly awesome code (and it is truly awesome!!!).
I will merge your fix right away, and close this issue once I do.
Thanks again for everything, Peter.
You are a good friend. :`)
from hyperion.
Resolved by merge "Fixed "XCF signalling stopped working" #16 (commit 1b91101).
Closing this issue as resolved.
Thanks again, Peter!
I will build and upload a new Windows pre-built with this fix in it as soon as I can.
from hyperion.
Related Issues (20)
- Visual Studio 17.9.0 generating warning C4789 HOT 1
- Missing support for clang builds under Windows MSVC HOT 32
- gmake check fails HOT 3
- Confusing response to 'stop' command HOT 9
- CCKDDIAG needs to provide support for shadow files HOT 1
- GIT: Additional gitignore files? HOT 1
- FORCE parameter on 'sf' command does not work correctly HOT 14
- Compiler warnings when building with gcc version 11.4.0 - a minor issue HOT 11
- some dasd tests pollute the repository with the shadow files HOT 3
- question about the __SSE2__ intrinsics ( x86intrin.h ) HOT 6
- CTCE links fail using TSAF under VM HOT 37
- Latest changes for Windows break build on Linux HOT 5
- Hercules just ends without completing processing config file on Windows 11 HOT 44
- standalone physical restore issue HOT 27
- Possible run zPDT CNF on Hercules? HOT 1
- message sequence repeated, two times before the quit command, one time after HOT 25
- A misconfigured CTCE causes Hercules to crash HOT 2
- Enhancement of 3390-108 Support HOT 6
- Configure issue on aarch64 HOT 1
- Vector Facility for z/Architecture HOT 83
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperion.