'make check' fails for a debug build

[sdl-hercules-390]

'make check' fails for a debug build

[Fish-Git]

I will try to reproduce it and get it fixed.

Thank you for reporting it.

QUESTION:

Does this happen only with Debug builds?

Or does it also happen with normal Release builds too?

Thanks.

[Fish-Git]

At the very end of Makefile.am I am seeing:

check:
if APPLE
    $(top_srcdir)/tests/runtest          $(top_srcdir)/tests
else
    $(top_srcdir)/tests/runtest -p .libs $(top_srcdir)/tests
endif

I suspect the -p .libs should not be there.

When I manually run /tests/runtest ./tests > ~/runtest.log 2>&1, all tests pass successfully:

[...]
Test sske#2.  53 OK compares.  All pass.
Test stfl and stfle.  12 OK compares.  All pass.
Test timeout.  1 OK compares.  All pass.
Test multix.  2 OK compares.  All pass.
Test multix1.  2 OK compares.  All pass.
Test zeos.  6 OK compares.  All pass.
Done 277 tests.  All OK.

I don't know why John felt -p .libs should be there. It seems dubious to me. I will try to reproduce your problem both with and without that parameter to see if that fixes your problem.

You can try it for yourself too in the mean time: simply remove the if APPLE, else and endif statements (as well as the suspect runtest statement) leaving ONLY the plain runtest command without and extra arguments. Then run your configure and make and make check again.

[Fish-Git]

Okay, I have tested make check with my Fish-Git Hyperion for both a normal Release mode build as well as for a --enable-debug Debug, and both work just fine as-is (i.e. with the existing -p .libs argument for the non-APPLE case).

In other words, I am unable to reproduce your problem.   :(

I will try the same tests again without the -p .libs argument to verify that works okay or not as well.

HOWEVER, I happened to notice that it appears, in your original problem report, that you simply did a configure followed immediately by a make check. If this is true, then this is very likely your problem! You must run make before you can do a make check!!

If you didn't do that, then please try again, e.g.:

configure ... && make && make check

Let me know if that works okay for you.

Thanks!

[Fish-Git]

Okay, I have completed the full suite of tests for both in-source builds as well as for out-of-source builds for both Debug builds as well as normal Release builds, both using runtest with the extra (but unneeded) -p .libs argument as well as without the -p .libs argument, and everything works beautifully. I am unable to reproduce your failure.

I strongly suspect (but did not bother to confirm) that you simply failed to run make before your make check. Please ensure you always to a make (after your configure) before you run make check.

I am closing this issue as I believe it to be a user error and am unable to reproduce the failure.

[mhoes]

Hi,

I did run 'make' to build Hyperion before I run the 'make check'. It only happens for a debug build, and not for a regular build. Leaving the "-p .libs" out of the command, and just running '../hyperion/tests/runtest ../hyperion/tests" makes no difference and results in the same error. I'm doing an 'out of source build'. I have attached my 'allTests.out', perhaps something can be learned from that.

allTests.out.gz

[Fish-Git]

Maarten,

I took a closer look at the tests I ran and apparently I wasn't testing what I thought I was testing!

You are 100% correct: make check does indeed fail exactly as you described for out-of-source Debug builds, and thanks to the allTests.out file you provided, I now know why.

My sincerest apologies for dismissing your problem too quickly!

Stay tuned. I shall have a fix for you shortly.

Thank you for your patience and persistence.

[Fish-Git]

Should be fixed now by commit eec676d.

Please re-pull and rebuild to confirm (autogen.sh, configure ..., make, make check).

I will await your confirmation first before closing this issue.

Thanks.

[mhoes]

Thanks, that commit does indeed fix the issue for me.