se-edu/addressbook-level2

:ab::two: A Java sample application for students. An AddressBook application that uses OOP basics.

AddressBook (Level 2)

• This is a CLI (Command Line Interface) Address Book application written in OOP fashion.

• It is a Java sample application intended for students learning Software Engineering while using Java as the main programming language.

• It provides a reasonably well-written code example that is significantly bigger than what students usually write in data structure modules.

Useful Links

• User Guide

• Developer Guide

• Learning Outcomes

Contributors

The full list of contributors for se-edu can be found here.

Contact Us

• Bug reports, Suggestions : Post in our issue tracker if you noticed bugs or have suggestions on how to improve.

• Contributing : We welcome pull requests. Follow the process described here

addressbook-level2's Issues

Rephrase method header comments to follow the convention

E.g. the 'overview statement' should be phrased to start wit a word such as Returns ... Converts ... etc.

Update I/O redirection system tests

Fix coding problem: reassigning parameters

ParserTest: fix naming standard violation

ParserTest:setup() should be setUp()

Update system tests to work through junit

From I/O redirection to junit

Use Optional where appropriate

Seems we used Optional in level 1, so no harm using it here.

Add learning outcome nested classes

Parts of address (block, etc.) can be nested classes of Address class.

Parser: Give some examples of parsing without regex

Let's give at least one example of parsing without regexes, to contrast the regex approach

Set up Travis CI

Although it is not a learning outcome of this level, we can still set up for the convenience of developers and contributors.

Limit regex to parser

Regex is non-essential, so we should limit its use.

Change file extension requirement from .txt to .xml

.txt is a legacy requirement from level 1.
This address book saves data in xml format, so the file should have the extension .xml

Set up coveralls reporting

Although it is not a learning outcome of this level, we can still set up for the convenience of developers and contributors.

Fix runtests.bat

The line to compile reads javac javac ...

Dev guide

StorageFile class: load method should not create a new file

The current load method creates an empty file if the file is missing.

1. This is not mentioned in the header comment.
2. Saving should not be the job of the load method in the first place.

Move all/most user-visible message to the Message class

This is something to explore.
Need to consider if it is the right thing to do.

Add runtests.sh

create a shell script to run the tests for Mac and Linux users

Add unit tests for Utils class

as per title

Broken links in [LO-JUnit] section

• [Quora post] What is the best way to avoid bugs

The link is completely missing.

• [Web article] The Big Cost of Software Bugs - An interesting post on 10 bugs that cost millions.

The link just redirects me to http://www.bloomberg.com/markets.

Incorrect user input should not cause exceptions

Invalid user inputs are not exceptional situations, and should not cause exceptions.
Also, it is preferred not to throw exceptions from constructors.

NullPointerException if viewall is used before list

The "viewall" command, produces a Null Pointer Exception, even when there is a person at given index. To replicate the issue add a few users and close the program. Then restart and try the first command as viewall 1. However, if we try the list command before viewall the issue disappears. From the code it turns out that viewall works on the last shown list and not the stored file. I am not sure if this was intended or not.

Add unit tests for AddCommand class

as per title

Add unit tests for UniquePersonList and UniqueTagList classes

as per title

User guide: Typo in add command description

The example 2 for command "add" (from the user guide) should be changed to: add Betsy Crowe pp/1234567 e/[email protected] pa/Newgate Prison t/criminal /friend

We need to add the phone number before other information (same as first example) to avoid invalid format error. The format/syntax mentioned in the user guide is correct.

Phone::isValidPhone rephrase header comment

Instead of Checks ..., phrase it as Returns true if ...

Unit testing example for parser

Add unit tests for AddressBook class

as per title

Names with unicode characters are treated as invalid

Noticed this happening in the last 2 test cases in input.txt. Think it might be caused by a letter being represented with 2 code points, in which case \p{L} wouldn't match.

Set up checkstyle

To ensure we do not get any code style violations in master.

Probably should be done after #112 is done.

A PR will also need to resolve all the current errors I get from master: (I copied over the checkstyle config from addressbook-level4)

[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/Main.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/Main.java:102: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/commands/IncorrectCommand.java:7:46: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/commands/IncorrectCommand.java:11:51: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Address.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Email.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Name.java:16: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Name.java:21: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/ReadOnlyPerson.java:24: Line is longer than 120 characters (found 125). [LineLength]
[ant:checkstyle] [WARN] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/tag/UniqueTagList.java:137:23: Name 'TagFoundAndDeleted' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:67: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:68: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:70: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:71: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:73: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:74: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:76: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:77: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:79: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:80: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:82: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:83: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:85: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:86: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:88: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:89: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:91: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:92: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:93: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:103:44: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/ui/TextUi.java:41:20: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/ui/TextUi.java:125:11: 'if' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:49: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:85: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:92: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:115: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:119: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:121: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:123: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:124: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:127: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:132: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:134: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:136: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:137: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:140: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:143: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:145: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:148: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:152: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:154: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:158: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:159: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:49: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:55: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:77: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:91: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:113: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:153: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:154: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:187: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:191: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:192: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:193: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:18: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:22: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:25: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:31: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:35: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:38: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]

Add unit tests for DeleteCommand class

as per title

Shift Parser#shouldIgnore into TextUi

Decouple parser and ui

Add unit tests for StorageFile class

as per title

Remove redundant TestUtils.createList()

Arrays.asList() can (and should) be used for creating a List<ReadOnlyPerson>, thus making TestUtils.createList() redundant.

Add different levels of comparison to equality methods of Person class

Add different levels of comparison to equality methods for Person. Sometimes we want to check if 2 persons contain same exact values (values of individual fields + privacy settings), and at other times, just to see if it is the same person (just field values). Also, Person.equals doesn't compare tags. Useful for simplifying testing.

Add unit tests for ViewAllCommand and ViewCommand classes

as per title

Test Failing due to incorrect message

***** actual.txt
|| Enter command: || [Command entered: add [][;] p/12345 e/[email protected] a/vali
d, address]
|| Names should consist of letters, spaces, numbers, ', - or .
|| ===================================================
***** EXPECTED.TXT
|| Enter command: || [Command entered: add [][;] p/12345 e/[email protected] a/vali
d, address]
|| Person names should be spaces or alphabetic characters
|| ===================================================

Commit related to this issue : #118

Person object should point to tags in the common tag list

Currently, each person has its own tag list. Instead of keeping Tag copies, a Person object should point to Tag objects in the common Tag list.

Add unit tests for FindCommand class

as per title

Remove polymorphic behavior

Polymorphic behavior should be removed as it is not one of the learning outcomes at level 2.
e.g.
execute()
toString()

User guide

Into README.md

Remove redundant Runnable interface from Main

Move person/tag creation code out of the parser

Parser should not be creating persons/tags. The AddCommand should contain the values given by the user rather than a Person object.

Remove unused imports

Fix code style violation

As reported by checkstyle in #123.

[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/Main.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/Main.java:102: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/commands/IncorrectCommand.java:7:46: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/commands/IncorrectCommand.java:11:51: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Address.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Email.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Name.java:16: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/Name.java:21: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/person/ReadOnlyPerson.java:24: Line is longer than 120 characters (found 125). [LineLength]
[ant:checkstyle] [WARN] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/data/tag/UniqueTagList.java:137:23: Name 'TagFoundAndDeleted' must match pattern '^[a-z][a-zA-Z0-9]*$'. [LocalFinalVariableName]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:0: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:67: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:68: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:70: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:71: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:73: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:74: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:76: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:77: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:79: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:80: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:82: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:83: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:85: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:86: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:88: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:89: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:91: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:92: 'case' child have incorrect indentation level 12, expected level should be 8. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:93: 'block' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/parser/Parser.java:103:44: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/ui/TextUi.java:41:20: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/src/seedu/addressbook/ui/TextUi.java:125:11: 'if' is not followed by whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:49: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:85: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:92: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:115: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:119: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:121: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:123: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:124: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:127: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:132: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:134: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:136: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:137: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:140: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:143: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:145: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:148: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:152: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:154: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:158: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/commands/DeleteCommandTest.java:159: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:49: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:55: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:77: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:91: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:113: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:153: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:154: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:187: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:191: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:192: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/parser/ParserTest.java:193: 'array initialization' child have incorrect indentation level 16, expected level should be 12. [Indentation]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:18: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:22: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:25: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:31: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:35: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
[ant:checkstyle] [ERROR] /home/pyokagan/pyk/addressbook-level2/test/java/seedu/addressbook/util/TestUtil.java:38: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]

Move inner/nested classes to the bottom of the file

e.g. AdaptedContactDetail

Use command objects to reduce clutter spread out across components

old discussion here

Remove unused empty contstructors

e.g. public ClearCommand() {}

Fix storage component

Extract parser class for command factory

Parser should take user input and construct the appropriate command object

String -> Command

Name regex doesn't match hyphen, dots and quote

For that matter, name regx doesn't match any non-ascii names