sebas77/svelto.ecs.tests

Svelto.ECS unit tests

svelto.ecs.tests's Issues

Native Operations enqueued in structural change callbacks won't always execute in the same set of submissions

                        //todo: proper unit test structural changes made as result of add/remove callbacks
                        while (enginesRootTarget.HasMadeNewStructuralChangesInThisIteration() 
                               && iterations++ < MAX_SUBMISSION_ITERATIONS)
                        {
                            hasEverSubmitted = true;

                            _enginesRoot.Target.SingleSubmission(profiler);
#if UNITY_NATIVE
                            if (enginesRootTarget.HasMadeNewStructuralChangesInThisIteration())
                                enginesRootTarget.FlushNativeOperations(profiler);
#endif
                        }

Due to the nested if (enginesRootTarget.HasMadeNewStructuralChangesInThisIteration()) being unaware of native operations before they are dequeued, a second submission has to be triggered for them to be executed, rather than the usual behaviour of non-native factories being executed in another submission iteration.

This nested if() seems unecessary as flushing native operations will enqueue them for the check inside the while().