secabstraction/powerwalker

powerwalker's Issues

Not exactly an issue.

Thank you for this repository! I dreaded importing all the functions to c#. So far I've been using c++/cli but this adds a lot of extra code which is prone to bugs. Anyways, I wanted to suggest a few improvements. It is not an issue here because you are not setting a symbol server but if you did, initializing the symbols on each stacktrace would be really slow. Initializing them just once and then passing the hProcess to the StackTrace function is much faster. Also, there is no reason to call LoadModules() as SymInitialize() does that for you. Setting the SYMOPT_DEFERRED_LOADS flag is also a great improvement. I would love to make a PR if you wish.

Profiler

@secabstraction, I've scanned through the code and have few questions. The Get-ProcessTrace does not parse correctly right now - is everything committed? I would also like to put the PSReflect module as a dependency module (as it's done in PowershellArsenal) and remove it from the project code. Also, I think it would be nice to split the code of Get-StackTrace and Get-ProcessTrace among several files - > 1000 lines of code is extremely hard to support and develop. What do you think? I could start working on that in my fork, but would like to first discuss the changes with you. Also, what is your plan for the profiler? I guess the current goal is to make Get-ProcessTrace work, parsing both managed and native stacks, am I right?