sedmelluq/jda-nas

Send JDA audio packets from a queue kept in a native library to avoid stutters due to GC pauses

jda-nas's Issues

jcenter deprecation

Hello.
I would like to ask if jda-nas will get moved to a new artifactory since jcenter is going down soon.

Project dead?

Does this even work anymore? I tried this on my bot and the bot doesn't play any audio after joining the voice channel.

Please make this work on arm

i beg, many thank-

Compilation error on linux-arm

https://gist.github.com/natanbc/90f7c1e2bf0eb5507ad086672aaa3470

These flags appear to be causing the error

jCenter is deprecated

publishing new packages to jCenter will stop working on 1/05/2021
and getting existing packages will stop working in 1/02/2022
see: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

The project should probably migrate to another repo.
Some honourable mentions: JDA's repo or mavenCentral

Possible memory leak in udp-queue-natives

With gcc-11 -fanalyzer (GCC 11 Static analysis)

jda-nas/udp-queue-natives/udpqueue/udpqueue.c:236:16: warning: leak of ‘bytes’ [CWE-401] [-Wanalyzer-malloc-leak]
  236 |         return result;
      |                ^~~~~~
  ‘manager_queue_packet’: events 1-6
    |
    |  218 | static bool manager_queue_packet(queue_manager_t* manager, uint64_t key, const char* address, int32_t port, void* data,
    |      |             ^~~~~~~~~~~~~~~~~~~~
    |      |             |
    |      |             (1) entry to ‘manager_queue_packet’
    |......
    |  221 |         uint8_t* bytes = malloc(data_length);
    |      |                          ~~~~~~~~~~~~~~~~~~~
    |      |                          |
    |      |                          (2) allocated here
    |  222 |         if (bytes == NULL) {
    |      |            ~ 
    |      |            |
    |      |            (3) assuming ‘bytes’ is non-NULL
    |      |            (4) following ‘false’ branch (when ‘bytes’ is non-NULL)...
    |......
    |  226 |         memcpy(bytes, data, data_length);
    |      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    |      |         |
    |      |         (5) ...to here
    |......
    |  229 |         bool result = manager_queue_packet_locked(manager, key, address, port, bytes, data_length, explicit_socket);
    |      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    |      |                       |
    |      |                       (6) calling ‘manager_queue_packet_locked’ from ‘manager_queue_packet’
    |
    +--> ‘manager_queue_packet_locked’: events 7-9
           |
           |  178 | static bool manager_queue_packet_locked(queue_manager_t* manager, uint64_t key, const char* address, int32_t port,
           |      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
           |      |             |
           |      |             (7) entry to ‘manager_queue_packet_locked’
           |......
           |  187 |         else if (!existed) {
           |      |                 ~
           |      |                 |
           |      |                 (8) following ‘false’ branch...
           |......
           |  207 |         if (queue->buffer_size >= queue->buffer_capacity) {
           |      |             ~~~~~~~~~~~~~~~~~~
           |      |                  |
           |      |                  (9) ...to here
           |
    <------+
    |
  ‘manager_queue_packet’: events 10-13
    |
    |  229 |         bool result = manager_queue_packet_locked(manager, key, address, port, bytes, data_length, explicit_socket);
    |      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    |      |                       |
    |      |                       (10) returning to ‘manager_queue_packet’ from ‘manager_queue_packet_locked’
    |......
    |  232 |         if (!result) {
    |      |            ~           
    |      |            |
    |      |            (11) following ‘false’ branch...
    |......
    |  236 |         return result;
    |      |                ~~~~~~  
    |      |                |
    |      |                (12) ...to here
    |      |                (13) ‘bytes’ leaks here; was allocated at (2)
    |

Darwin natives for udp queue missing in published artifacts

Ahoy, the libudpqueue.dylib darwin native added to this project through #1 is missing in the published artifacts on jcenter. I believe this can be fixed by a correct rebuild?

Windows build 1.1.0 version

In the maven repository there is no windows build for udp queue