segmentio/go-athena

Golang database/sql driver for AWS Athena

go-athena's Issues

Alternative to prepared statements?

As you write here https://github.com/segmentio/go-athena/blob/master/conn.go#L24 Athena doesn't support prepared statements, which is true.

My question is how do I safely build queries where part of the query is user input.

The database/sql package wants us to use prepared satements and doesn't seem to offer any alternative.
I wasn't able to to find anything regarding sql santization/escaping in golang, besides "use sql.Query"

Simulate Prepared Statements by Interpolating Query Parameters

I believe prepared statements could be simulated by interpolating the parameters. go-sql-driver/mysql does something similar here.

Would a PR for something like this be considered?

Potential Problems/Solutions

• time.Time can map to timestamp, timestamp with time zone, or date. Each requires a different format.
  • The only real option I see here is defining a type for each that implements the driver.Valuer interface.
• Ensuring correct sanitation could be difficult. I've had a difficult time finding any specifics regarding how Athena differs from Presto in this regard.
  • I think this could be solved with a robust test suite.

Add go-athena to Golang SQLDrivers wiki

Hi,
Really appreciate the great work for this package.

I suggest you add this package into Golang SQLDrivers wiki for better and widely adoption
https://github.com/golang/go/wiki/SQLDrivers

Request for tagged releases

I wonder if you could provide tagged releases for vendoring purposes? Thanks.

Support for DDL statements?

Based on pull request #10, it looks like DDL statements are supported. Is that correct?

Adding support for amazon STS

Hi, I have added support for amazon STS for assuming an IAM role.
Very handy for software being developed and rolled out without need for usual credential's.

If you can give me access, I can submit the pull request.

thanks

Support athena workgroups

AWS release workgroups for Athena to support tags.
https://aws.amazon.com/about-aws/whats-new/2019/02/athena_support_for_tags/
Tagging Workgroups allows you to allocate costs, get detailed billing reports across Workgroups as well as define IAM permissions on Workgroups based on these tags

There is an PR by @jkatagi #26

Can anyone help review and merge this?

rows get missing when multiple pages are fetched

Hi,

We recently tried to use your awesome project on Athena, but during testing we found some data is not returned. Upon investigating i found that whenever fetchNextPage is called, it skips the first row assuming it is a header, which is true for the first page only. The subsequent pages don't have this, so the first row gets missed. I hope you guys can take a look into this matter.

Support for Array data-type

Hi,
I noticed that this library does not support Athena's array data-type,
https://docs.aws.amazon.com/athena/latest/ug/data-types.html

Is there a plan to add this?