Giter Site home page Giter Site logo

Comments (2)

selfshadow avatar selfshadow commented on August 16, 2024

First, thanks for the awesome work on LTC! Very cool!

Thanks!

The WebGL demo, BGFX-based demo and reference fitting code that are linked to in the Unity post should all be consistent with one another and represent a snapshot in time when the paper was published. I don't think it makes sense to update these, since then they will diverge too much from the paper itself, but perhaps we can add a link to the GitHub repository.

The repository is intended as an evolving reference, with changes that reflect current best practice (a more accurate edge integral, a different matrix normalisation that's more numerically stable, a slightly different LUT parameterisation...) as well as additions, such as the line and disk lights that come from followup work.

I can see now that it was wishful thinking on my part that people would look at the commit history and see that changes had been made to the LUT format. I'll update the readme to document this and the other changes.

Then there are the demos linked to by the readme on this repository which are here:

Sorry for the confusion here. I obviously forgot to update the linked demos when I made changes to the repository. I'll fix that shortly.

Those use the following for MinV:

Just to be clear, it's Minv as in the inverse of M, not MinV, the minimum of some variable V. :)

from ltc_code.

natevm avatar natevm commented on August 16, 2024

That makes sense. I think so long as the demos linked by the readme are updated, and perhaps with a note that the lookup table changed, that should be a good enough hint for anyone trying to implement LTC in their own projects.

Thanks!

from ltc_code.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.