semaphoreci/agent

Agent for running Semaphore 2.0 jobs

agent's Issues

Output buffering is sub-optimal for dot style test formatters

A customer reported this issue, and I was also able to reproduce it. A better buffering scheme is necessary.

Document how to start an Agent

Replicated command start lines

Missing "bash" is not reported as job log

Example:

2019/07/23 09:33:01.882436 job.go:314: {"directive":"Pulling docker images...","event":"cmd_finished","exit_code":0,"finished_at":1563874381,"started_at":1563874377,"timestamp":1563874381}
2019/07/23 09:33:01.882441 docker_compose_executor.go:123: Starting stateful shell
2019/07/23 09:33:01.882727 docker_compose_executor.go:351: Waiting for initialization
2019/07/23 09:33:01.882739 docker_compose_executor.go:356: (tty) export PS1=''
2019/07/23 09:33:01.882744 docker_compose_executor.go:356: (tty) stty -echo
2019/07/23 09:33:01.882748 docker_compose_executor.go:356: (tty) echo stty `stty -g` > /tmp/restore-tty
2019/07/23 09:33:01.882751 docker_compose_executor.go:356: (tty) cd ~
2019/07/23 09:33:01.882755 docker_compose_executor.go:356: (tty) echo '87d140552e404df69f6472729d2b2c3'
2019/07/23 09:33:02.260709 docker_compose_executor.go:356: (tty) Creating network "tmp_default" with the default driver
2019/07/23 09:33:03.629848 docker_compose_executor.go:356: (tty) Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "exec: \"bash\": executable file not found in $PATH": unknown
2019/07/23 09:33:03.668329 docker_compose_executor.go:362: Initialization complete

The Job log output should indicate that there is an issue.

Agent does not stop job processing immidiately if docker image is not found

Example:

Idempotent job scheduling should return the same answer

Docker Password with special shell characters prevents docker login for Compose Style

Example:

If the password contains a shell quote, e.g: hello"dasda@das#adasda, our approach of providing the password breaks the shell:

echo "hello"dasda@das#adasda" | docker login ...

Two solutions I see in this situation:

1. base64 while injecting, and dynamical decode in the machine
2. Store to a file, do cat passord_file.txt | docker login...

Will have to test the two approaches to figure out which is the best one to use.