sendbird/sendbird-chat-sample-ios

This repository provides feature-level Chat samples with Swift.

sendbird-chat-sample-ios's Issues

Open Channel/ iOS-delete message

They can also delete messages.

Group Channel/ iOS-Display Open Graph tags in a message

Supports the URL link preview when a message text contains the URL of a web page.

Group Channel/ iOS-Freeze and unfreeze channel

Operators can freeze various functions in a channel to stop members from chatting in the channel. Operators can also unfreeze the channel so that the members can chat with one another again.

Test on device

Implementing the ViewModel through delegation rather than inheritance

전체 ViewController를 재사용하기 쉽지 않은데, ViewModel or UseCase 레벨로 로직을 공유하는 것은 비교적 현실적인 것 같다.
BaseGroupChannelListViewModel 이런거 만들어 두면 하위 FeatureGroupChannelListViewModel 에서 기능 위임을 통해서 기본 기능을 쓸 수 있도록 만들 수 있는 방법을 고민할 필요가 있다.

Delegate를 통해서 ViewModel의 Output을 정의하고 있는데,
BaseViewModel의 Delegate를 FeatureViewModel의 Delegate로 간편하게 Proxy 해줄 수 있는 방법이 필요하다.

Modify the login flow to be the same as the Android sample app

1. Connect with only id without entering nickname.
2. For users who do not have a nickname, a screen to edit nickname is displayed.

Show Pending status

Group Channel/ iOS-Categorize messages by custom type

Specify a custom message type to subclassify messages and can be useful in searching or filtering messages

Group Channel/ iOS-Mark messages as read

When any of the members in a group channel reads a message, sendbird server notifies the event to the client apps of all channel members.

Group Channel/ iOS-Typing indicator

Shows when someone in the group channel has started typing "Bob is typing.." or "Bob, Alice and 2 others are typing.." using the onTypingStatusUpdated() event handler, and set this state using startTyping() and endTyping() to update the group members

Open Channel/ iOS-Report a message, a user, or a channel

a user can report suspicious or harrassing messages as well as the other users who use abusive language. The user can also report channels if there are any inappropriate content or activity within the channel.

Open Channel/ iOS-Add extra data to message

A message can have extra data of key-values items for further actions in an open channel.

Retrieve a list of members

Member API 통해서 load more

"닉네임 (online)" 으로 표시하기

흐름은 안드로이드 샘플앱 참고

Request Code Review

1. UseCase 객체 분리한 부분 어색하지 않을지
2. https://github.com/sendbird/examples-chat-ios/blob/main/CommonModule/CommonModule/UseCase/GroupChannel/GroupChannelMessageListUseCase.swift 에서 var messages: [SBDBaseMessage] 관리해주고 있는데 insert, append, filter 적절하게 사용하고 있는지
3. https://github.com/sendbird/examples-chat-ios/blob/main/CommonModule/CommonModule/UseCase/OpenChannel/OpenChannelMessageListUseCase.swift 에서 var messages: [SBDBaseMessage] 사용하고 있는데 insert, append, filter 적절하게 사용하고 있는지
4. UseCase를 확장하고 싶을 때 어려움은 없을지
5. Basic 프로젝트를 복제해서 Feature 프로젝트를 만들도록 가이드 하려 하는데, 더 나은 방법이 있을지

Open Channel/ iOS-Send and receive structured data (ex. json)

In addition to texts, images and videos, participants can create structured messages such as product information for drawing card style UI and location information with map thumbnails.

Group Channel/ iOS-Categorize channels by custom type

Manages channels by manually setting channel classification criteria such as conversation topics and hashtags.

Open Channel/ iOS-Channel metadata and metacounter

Users can store and manage (create, update, retrieve, delete) additional information such as the number of likes or the background color of a channel.
Users can manage (create, update, increase, decrease) additional information to channels such as the tracking number of likes with channel metacounter,

Group Channel/ iOS-Caching with Local Caching

https://sendbird.com/docs/chat/v3/ios/guides/local-caching

Open Channel/ iOS-Freeze/Unfreeze channel

In a frozen channel, participants can't chat one another but the operators can send a message to the channel.

Open Channel/ iOS-Mention other participants in message

When user IDs are mentioned in a message, the mentioned IDs will be notified with notifications.

Open Channel/ iOS-Copy message

They can also copy messages.

Group Channel/ iOS-Mention other members in message

When user IDs are mentioned in a message, the mentioned IDs will be notified wih notifications.

Open Channel/ iOS-Message threading

Allow a collection of messages to be grouped together, consisting of a parent message and its replies.

Last message of channel

마지막 받은 메세지 표시해주기

Migrate SDK v3 -> v4

- import SendbirdSDK 
+ import SendbirdChat

- SBDUser 
+ User

- SBDGroupChannel 
+ GroupChannel

- SBDError
+ SBError

- SBDBaseMessage
+ BaseMessage

- SBDOpenChannel
+ OpenChannel

Commonize Image Picker code

Show creation time in message

Copy message

클립보드 복사

Update Design Document

영어로 업데이트 필요함
https://sendbird.atlassian.net/wiki/spaces/SDK/pages/1767702756/iOS+Design+Guide

Open Channel/ iOS-Generate thumbnails of file message

An auto generated thumbnail image will display when sharing images or videos.

Open Channel/ iOS-Display Open Graph tags in a message

supports the URL link preview when a message text contains the URL of a web page.

Divide Feature Samples

요구사항 엑셀에 feature가 너무 잘게 나눠져있는데 실제 샘플 앱은 어떤 단위로 나눠야할지 고민 필요

Group Channel/ iOS-Ban and unban users from channel

Operators can remove any users that behave inappropriately in the channel and are not allowed to join the channel until a certain period of time set by the operators.

Test

Open Channel/ iOS-Send an admin message to channels

Operators and admins can send admin messages to participants to channels.

Open Channel/ iOS-Categorize channels by custom type

Users can manage channels by manually setting channel classification criteria such as conversation topics and hashtags.

Group Channel/ iOS-Message threading

Allow a collection of messages to be grouped together, consisting of a parent message and its replies.

Project management tool

프로젝트를 여러번 생성해야 함. tuist 사용해보면 어떨까?
https://okanghoon.medium.com/xcode-%ED%94%84%EB%A1%9C%EC%A0%9D%ED%8A%B8-%EA%B4%80%EB%A6%AC%EB%A5%BC-%EC%9C%84%ED%95%9C-tuist-%EC%95%8C%EC%95%84%EB%B3%B4%EA%B8%B0-6a92950780be

Group Channel/ iOS-Channel types

Private group channel: a user can join the chat through an invitation by another user who is already a member of the chatroom.
Public group channel: a user can join the chat without invitation from others.

A normal group channel (default setting) can accommodate up to 100 members and a Supergroup channel can accommodate up to 2000 members and can stretch up to 20K members depending on the sendbird plan.

Open Channel/ iOS-Update message

They can also update messages.

Fix scroll action when scroll indicator is reached top or bottom

I have changed the message fetching direction to forward.
Because using forward direction fetching is make understanding the business logic easier for developers.
However, It's hard to present UI with the forward direction message fetching.

So I will fetch messages in the reverse direction.

Use only one workspace

Laying out apps flat

Feedback

이슈 설명

• 니즈: Feature 별로 나눠서 예제를 보고 싶음, 그런데 유지보수성도 좋게 하고 싶음
• 회의: https://sendbird.atlassian.net/wiki/spaces/~139733142/pages/1758857393/1+22+-+Sample+2.0
• 참고: https://github.com/sendbird/examples-calls-ios
• 진행: 전체적인 설계, Base Sample 까지만 구현. 나머지 구현은 외부로 맡김

질문

• Sample 앱 간의 구조 괜찮을지
• 앱을 하나만 두고, 화면 나눠서 feature 나열하는건 어떨까? JS 팀에서 하려는 방식: feature 단위로 코드 참고를 하기 위함인데, 하나의 앱으로 하면 코드 참고하기가 어려움
• Calls 샘플 앱 만들 때 겪었던 어려움 파악
• Common 에 공통 로직을 두고 확장을 할 때는 상속해서 만드는 구조는 괜찮을지
• 세부 feature 들을 각각 Sample App으로 만드는 것이 요구사항인데, 어떤 기준으로 나누면 좋을지 고민이 됨
• 내부 아키텍쳐는 어떻게 하면 좋을까?
  • MVC 기본형태에 공통적인 비즈니스 로직 Common 으로 모아두기
  • 어려운 아키텍쳐를 골랐다가 핵심을 오히려 파악하기 어려워질 수도 있겠다는 생각
  • MVC, VIP, ...
  • MVVM도 후보로...! <- UIKit 프로덕트 구경하기
• 근본적인 접근 방식이 잘못된 건 없을지 확인

의견

• ⭐️ 로직 중심으로 기능 공유하도록 만들기
  • 로직만 깔끔하게 떼어낼 수 있으면 좋겠음
  • View / Logic 구분 잘되어 있으면 좋겠음
  • ⭐️ 의존성 최소화 시키기
• BaseChannel: Common에 포함
  • Group: 각자 샘플 앱
  • Open: 각자 샘플 앱
• Common 의 확장성이 관건일듯...!!!

Crash when registering 3 users in ProfileImageView

I imported the code from an old sample app, but there is a bug.
Re-creating StackView is inefficient and needs improvement.

sendbird-chat-sample-ios/Modules/CommonModule/Sources/View/User/Profile/ProfileImageView.swift

Lines 75 to 95 in aa75e77

	if users.count == 1 {
	mainStackView.addArrangedSubview(imageContainerView)
	} else {
	let stackView = UIStackView(frame: CGRect(x: 0, y: 0, width: self.frame.width, height: self.frame.height))
	stackView.addArrangedSubview(imageContainerView)
	stackView.axis = .vertical
	stackView.distribution = .fillEqually
	stackView.spacing = spacing
	imageView.heightAnchor.constraint(equalToConstant: imageContainerView.frame.height).isActive = true
	imageView.widthAnchor.constraint(equalTo: imageView.heightAnchor).isActive = true
	if mainStackView.arrangedSubviews.count < 2 {
	mainStackView.addArrangedSubview(stackView)
	} else {
	mainStackView.arrangedSubviews
	.compactMap { $0 as? UIStackView }
	.filter { $0.arrangedSubviews.count == 1 }
	.forEach { $0.addArrangedSubview($0) }
	}
	}

Open Channel/ iOS-Categorize messages by custom type

Specify a custom message type to subclassify messages and can be useful in searching or filtering messages.

Add channel name change function

Investigate how to manage with Tuist

I don't have enough time, but if this doesn't work, it seems too much trouble to expand the project.

Open Channel/ iOS-Send and receive various types of files

In addition to texts, images and videos, participants can send and receive various types of files, such as PDFs (the maximum file size limit varies depending on your subscription plan.

Check sending messages function when offline

Group Channel/ iOS-Hide or archive channel from a list of channels

Hides channels and prevents them from appearing when listing group channels. When a new message is received on a channel, the channel will automatically appear back in the list. You can also archive a channel from the list, and unarchive it when needed.