sentaroh / smbsync3 Goto Github PK
View Code? Open in Web Editor NEWImproved version of SMBSync2
License: MIT License
Improved version of SMBSync2
License: MIT License
I use v2 very often in my home network. It's super handy . Thank you man ๐.
Hi,
Out of curiosity I looked quickly at the sync code in your current version. I know it is beta, so I never looked at it before, but I see that you largely edited the sync checks to delete files and they are again broken like before
I did not look at the filters checks if code was changed for isFileSelected() and is DirectoryToBeProcessed() but the implementation was also optimized for overhead. The only project I know of and that has a non broken code is the one I linked at (wildcard-project). However, they use a char by char check instead of ever calling a pattern check. Speed is same but more prone to custom code bugs. Hope you deeply verify and check all possibilities if you modify it.
Note: I am taking a long break and do not plan to push commits except fr/en translations from time to time. I plan to migrate to Android R by end of year or begin 2021, so I am not migrating before that to SMBSync3 and won't really look at it before.
I will push the xda and Phone Android threads since the fixed filters v2 is now enabled.
Thank you for your free time on the project and Best regards
Hi
Can you clarify if you are still maintaining SMBSync3 ?
I looked at the code and tried to fix the most annoying functional bugs:
#4
I will look at the filters and the option to save app settings to user selectable directory
However, could you at least implement the changes to save changes in the List SMB Shares dialog and Select SMB Server from scanner dialog on screen rotation ? That part is rather large for me as it seems like it needs implementing a dedicated activity like the CommonFileSelector2 !
Thank you and best regards
I tested this version on the Emulator for the first time
I do not have much time currently to start looking at the code and testing before using it for daily jobs. However, I can test the GUI and some functions from time to time if you think the version is enough stable in development for some beta/alpha testing
Here are a few bugs I found. I did not test the core functions however.
1. Bug in item language apply translation
The below item is set to different language than main layout:
2. NonWrapping text in dialogs
Many dialogs have Non Wrapping Text. I do not for Chinese/Japanese, but for occidental languages, we cannot properly read a non wrapped text. It is not how it is written
3. Menus Alignement
The "Advanced Options" menu should be aligned with "Options" Menu and the submenus aligned back to where "Advanced Options" is now aligned (one less level of indent for the Advanced Options). That way, space and screen appearance is better adjusted (like implemented in SMBSync2)
Best regards
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.