sergiioo/tslint-defocus

A tslint rule to nag you when you forget that you have focused some Jasmine tests with 'fdescribe' or 'fit'

tslint-defocus's Issues

Typescript version warning

Thanks for this very useful package, I used to commit fits and fescribes on a regular base, but now with tslint-defocus our pre commit hooks and CI pipeline catches these quite well.

However, both with Typescript 2.9.2 and 3.1.1 I am receiving this warning message for npm install:

[email protected] requires a peer of typescript@^2.x | ^3.x but none is installed. You must install peer dependencies yourself.

Is anybody else having the same issue?

Remove @types from dependencies

Hi Sergiioo,

we would like to include your lib (v 2.0.2) into our project but unfortunately it installs further TS types which conflict with our previously used types (mocha vs. jasmine). Would be great if you could remove them from the deps in your package.json and put them to the devDependencies and republish the version or publish a new version for it.

Thx in advance!

TSlint 5.x

Hi,
is it possible that this plugin is not compatible with TSlint version 5.x? :)

I swore I seen it working in my project but after updating to 5.x there are no errors.

Package cannot be used in a shared library

It is not possible to use tslint-defocus in shared libraries. Specifically, when tslint-defocus rules are defined via rulesDirectory in a shared library, which is then consumed by other libraries, running tslint on the other libraries leads to a Could not find custom rule directory error.

This has been reported elsewhere, e.g. here: palantir/tslint#3827. A similar issue was raised, and later fixed, in the tslint-eslint-rules library here: buzinas/tslint-eslint-rules#165.