sergiiz/rxbasicskata

Practical challenges for RxJava learners

rxbasicskata's Issues

Broken with AS 3

I had downloaded and tried this repo before, all worked fine. Recently I download the repo again but it doesn't anymore. The problem seems to be related to Android Studio and IntelliJ. Anyone have workarounds?

Class not found: "org.sergiiz.rxkata.CountriesServiceSolvedTest"Empty test suite.

Kata feedback

I took the challenge:

listOnly3rdAnd4thCountry

Lists are 0 based thus the 3rd item is at index 2 yet the matching test expects index 3 and 4.

getCurrencyUsdIfNotFound

The expected format for the default value should be defined upfront, I thought the default response should be "Usd" but the test expects "Usd (Default)"

isPopulationMoreThan1Million

The method name doesn't indicate that the user should check if all countries in the list have more than 1M population, the Single<Boolean> result type may also indicate to check if any of the countries is over 1M.

rx_ListPopulationMoreThanOneMillion_FutureTask

It is reasonable to expect that when the user sees Future or FutureTask he/she will use fromFuture(Future, Scheduler) to make sure any potential blocking on Future.get() doesn't block the subscribing thread. The test is not ready for this and may fail the test.

rx_CountryNameInCapitalsWithNPE

RxJava 2 is largely a non-null library and nothing indicates the Country.name may be null. In addition, the test expects a particulare string to be returned for the null name.

For some reason test is not running

For some reason test is not running in android studio, only in intellij idea and after some settings change. Just nothing happens when I am running test. Can you help with that?

Cloning the project — can't see a module directory

Hello, Sergii.

1. I've copied the repository link
2. Inserted it to Android Studio → Project from VC → GitHub
3. And imported it without errors. But:

Problem
I can't see the rxkata module, which contains code and tests. I'm using both Project and Android perspective in the Project View.

Note
It's probably just a lack of knowledge about Gradle on my side, but I'd be grateful it you can help. Perhaps a few other people are also searching for the solution.

And in any case, thank you for creating this project.

Flattening the gradle multi-project?

Hi Segii,

thanks for the nice articel and the kata, I really enjoyed it.

Is there any reason why you did a gradle multi-project? A simple gradle project would be enough and simpler...

Best regards,
Peti