sergiobenitez/devise

Library for devising derives and other procedural macros.

devise's Issues

Mismatching of `quote!` with `quote_spanned!` in some macros

rust-lang/rust#68716 would change the default for quote! from call_site to mixed_site. As expected there is some breakage, but it looks like the breakage caused by devise specifically is "legitimate" and caused by mismatching quote! with quote_spanned!. For example:

Devise/codegen/src/lib.rs

Line 74 in c4f110f

match __list.next() {

is in a quote_spanned! invocation, but

Devise/codegen/src/lib.rs

Line 120 in c4f110f

let mut __list = match __meta {

is in a quote! invocation.

My opinion is that these should be realigned such that quote! is used consistently for variables such as __list, which should work even after a switch to mixed_site.

Cannot build docs with Rust nightly

When generating docs for my Rocket project, Cargo bails out while trying to document the devise crate:

 Documenting devise v0.2.0
error[E0275]: overflow evaluating the requirement `alloc::raw_vec::RawVec<(devise_core::syn::Lifetime, devise_core::syn::token::Add)>: std::marker::Unpin`
  |
  = help: consider adding a `#![recursion_limit="128"]` attribute to your crate
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::Lifetime, devise_core::syn::token::Add)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::Lifetime, devise_core::syn::token::Add>`
  = note: required because it appears within the type `devise_core::syn::LifetimeDef`
  = note: required because it appears within the type `(devise_core::syn::LifetimeDef, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `*const (devise_core::syn::LifetimeDef, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `std::ptr::Unique<(devise_core::syn::LifetimeDef, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<(devise_core::syn::LifetimeDef, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::LifetimeDef, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::LifetimeDef, devise_core::syn::token::Comma>`
  = note: required because it appears within the type `devise_core::syn::BoundLifetimes`
  = note: required because it appears within the type `std::option::Option<devise_core::syn::BoundLifetimes>`
  = note: required because it appears within the type `devise_core::syn::TraitBound`
  = note: required because it appears within the type `devise_core::syn::TypeParamBound`
  = note: required because it appears within the type `(devise_core::syn::TypeParamBound, devise_core::syn::token::Add)`
  = note: required because it appears within the type `*const (devise_core::syn::TypeParamBound, devise_core::syn::token::Add)`
  = note: required because it appears within the type `std::ptr::Unique<(devise_core::syn::TypeParamBound, devise_core::syn::token::Add)>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<(devise_core::syn::TypeParamBound, devise_core::syn::token::Add)>`
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::TypeParamBound, devise_core::syn::token::Add)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::TypeParamBound, devise_core::syn::token::Add>`
  = note: required because it appears within the type `devise_core::syn::TypeParam`
  = note: required because it appears within the type `devise_core::syn::GenericParam`
  = note: required because it appears within the type `(devise_core::syn::GenericParam, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `*const (devise_core::syn::GenericParam, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `std::ptr::Unique<(devise_core::syn::GenericParam, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<(devise_core::syn::GenericParam, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::GenericParam, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::GenericParam, devise_core::syn::token::Comma>`
  = note: required because it appears within the type `devise_core::syn::Generics`
  = note: required because it appears within the type `devise_core::syn::ItemType`
  = note: required because it appears within the type `devise_core::syn::Item`
  = note: required because it appears within the type `devise_core::syn::Stmt`
  = note: required because it appears within the type `*const devise_core::syn::Stmt`
  = note: required because it appears within the type `std::ptr::Unique<devise_core::syn::Stmt>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<devise_core::syn::Stmt>`
  = note: required because it appears within the type `std::vec::Vec<devise_core::syn::Stmt>`
  = note: required because it appears within the type `devise_core::syn::Block`
  = note: required because it appears within the type `devise_core::syn::ExprIf`
  = note: required because it appears within the type `devise_core::syn::Expr`
  = note: required because it appears within the type `devise_core::syn::TypeArray`
  = note: required because it appears within the type `devise_core::syn::Type`
  = note: required because it appears within the type `devise_core::syn::GenericArgument`
  = note: required because it appears within the type `(devise_core::syn::GenericArgument, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `*const (devise_core::syn::GenericArgument, devise_core::syn::token::Comma)`
  = note: required because it appears within the type `std::ptr::Unique<(devise_core::syn::GenericArgument, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<(devise_core::syn::GenericArgument, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::GenericArgument, devise_core::syn::token::Comma)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::GenericArgument, devise_core::syn::token::Comma>`
  = note: required because it appears within the type `devise_core::syn::AngleBracketedGenericArguments`
  = note: required because it appears within the type `devise_core::syn::PathArguments`
  = note: required because it appears within the type `devise_core::syn::PathSegment`
  = note: required because it appears within the type `(devise_core::syn::PathSegment, devise_core::syn::token::Colon2)`
  = note: required because it appears within the type `*const (devise_core::syn::PathSegment, devise_core::syn::token::Colon2)`
  = note: required because it appears within the type `std::ptr::Unique<(devise_core::syn::PathSegment, devise_core::syn::token::Colon2)>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<(devise_core::syn::PathSegment, devise_core::syn::token::Colon2)>`
  = note: required because it appears within the type `std::vec::Vec<(devise_core::syn::PathSegment, devise_core::syn::token::Colon2)>`
  = note: required because it appears within the type `devise_core::syn::punctuated::Punctuated<devise_core::syn::PathSegment, devise_core::syn::token::Colon2>`
  = note: required because it appears within the type `devise_core::syn::Path`
  = note: required because it appears within the type `devise_core::syn::Attribute`
  = note: required because it appears within the type `*const devise_core::syn::Attribute`
  = note: required because it appears within the type `std::ptr::Unique<devise_core::syn::Attribute>`
  = note: required because it appears within the type `alloc::raw_vec::RawVec<devise_core::syn::Attribute>`
  = note: required because it appears within the type `std::vec::Vec<devise_core::syn::Attribute>`
  = note: required because it appears within the type `devise_core::syn::FieldPat`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0275`.
error: Could not document `devise`.

Toolchain information:

> rustc --version && cargo --version
rustc 1.38.0-nightly (6e310f2ab 2019-07-07)
cargo 1.37.0-nightly (4c1fa54d1 2019-06-24)

Is rust-nightly a hard requirement for Devise by design?

I don't really know Rust and it's ecosystem, so asking, to make sure, that Devise requires rust-nightly by design, on purpose. I'm compiling code which deep down in dependency chain requires Devise:

$ rustc --version                                                                                                           
rustc 1.46.0

$ cargo build
...
   Compiling devise_core v0.2.0
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/mkucharski/.cargo/registry/src/github.com-1ecc6299db9ec823/devise_core-0.2.0/src/lib.rs:1:1
  |
1 | #![feature(proc_macro_diagnostic, proc_macro_span)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/mkucharski/.cargo/registry/src/github.com-1ecc6299db9ec823/devise_core-0.2.0/src/lib.rs:2:1
  |
2 | #![feature(crate_visibility_modifier)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/mkucharski/.cargo/registry/src/github.com-1ecc6299db9ec823/devise_core-0.2.0/src/lib.rs:3:1
  |
3 | #![feature(concat_idents)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0554`.
error: could not compile `devise_core`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Is rust-nightly a hard requirement on your side, or would it be possible to drop features in the code, which would make it usable on rust-stable?