serilog-contrib/serilog-sinks-teams

A Serilog event sink that writes to Microsoft Teams

serilog-sinks-teams's Issues

Add Serilog Sink icon to Serilog.Sinks.MicrosoftTeams NuGet package

The Serilog.Sinks.MicrosoftTeams NuGet package doesn't have an icon yet.

I suggest using the standard icon for sinks:

---

More details: https://github.com/serilog-contrib/brand

Possible Close and Flush Error

Hi, I been using this sink in a console app and have notice that if the application quits before the "Serilog.Sinks.PeriodicBatching" OnTick event has been run then the logs in the queue are lost.

After looking at the "MicrosoftTeamsSink.cs" I believe this maybe due to the order in which things are disposed, in the Dispose() method.

Currently the HttpClient is disposed first then the Base Dispose method is called where it tries to flush the buffer however I would assume this fails because the HttpClient is no longer valid, thus dropping the buffer.

I have tried to SelfLog to test this theory but noting is outputted to the temp file I created, which also leads me to believe that it may not even get to the Dispose method as well.

Any help would be great as really like this sink :)

Use NetStandard 2.0

Is there any chance of using Netstandard 2.0 so we can use it with .Net Full Framework 4.7.2?

Enhancement Idea - Performance and HTTP Call

@DixonDs First off, great work 👍

Might be an idea to look at the Http Sink and to use a buffer and proper async call to enhance performance.

Or use this as a base similar to how the loggly sink uses it.

Batching of the same log events

Now, when we use periodic batching sink (#2), it should be quite straightforward to group the same log events into a single Teams message and instead add additional properties to the Teams message like Count and, maybe, something like FirstOccurredDate/OccurredLastDate.