Comments (3)
Hi @ylashin
For this one, I think it may be a bit dangerous/tricky/risky to enable that by default (because of streamed contents that we don't want to consume, and possibly binary stuff or large chunks of data ...).
I wonder if it would be better to enable that as an "opt-in" mechanism for specific needs, for instance by explicitly adding some object to capture in the log event ...
This could look something like :
Context.AddToSerilogWebLogEvent("RequestContent", something, destructure: false)
(Context
being an HttpContext
or HttpContextBase
or something of this family, i.e. something that lives for the duration of the request and can store arbitrary objects in a dictionary )
And then, when generating the event at the end of the request, the module could look in there and enrich the event with the registered properties ...
This mechanism could then be used directly from a given Controller Action / WebForm page , or more generically, for instance in MVC or WebAPI ActionFilter
s / ExceptionFilter
s ...
from classic.
Thank @tsimbalar , your suggestion would work fine but I was actually thinking of something like
ApplicationLifecycleModule.LogPostedFormData = LogPostedFormDataOption.Always;
ApplicationLifecycleModule.FilterPasswordsInFormData = true;
Currently the above logs posted form data only. My idea is to have another flag to log the full HTTP payload in certain cases (e.g. JSON content type and failed HTTP request)
from classic.
This would be a welcome addition when working with WebAPI calls in dev, test and staging. Should be configurable to disable it through appsettings in a production transform.
I guess the existiong Serilog functionality in
.Destructure.ToMaximumStringLength(x)
whould be in effect if POST payload is too big?
from classic.
Related Issues (20)
- Calling cfg.LogAtLevel to set the LogEventLevel seems to disable HTTP request logging? HOT 8
- UserName enricher shows (anonymous) in ApplicationLifecycleModule with Microsoft.AspNet.WebApi.* >= 5.2.5 HOT 5
- Applicationlifecycle module question HOT 7
- Using the EnvironmentUserName if none? HOT 2
- HttpModule stops working when stressed. HOT 6
- Exception with null key in form data HOT 3
- EnableFormDataLogging not logging anything with WebApi HOT 2
- .netStandard v2 version ? HOT 1
- HttpRequestUrlEnricher gives "Request is not available in this context" exception HOT 6
- Special cases when using `FilterKeywords()` with `EnableFormDataLogging()` HOT 5
- ASP .NET Core enrichers? HOT 2
- Add Http Data To All Logging Events HOT 1
- How to troubleshoot the ApplicationLifecycleModule HttpModule is loading and configured properly? HOT 6
- WithUserName Only Working With HttpModule Logging But Doesnt Log During Web Service/API Logs HOT 8
- HttpModule isn't extensible? HOT 2
- SerilogWeb.Classic IIS classic mode incompatibility HOT 1
- Customize HttpRequestEventMessageTemplate HOT 6
- Log CorrelationId with SerilogWeb.Classic's log entries HOT 2
- IIS Web application hang up after multiple requests stuck on "Begin request" HOT 1
- Multiple log messages for single Request with error 404 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classic.