Request for new functionality in HttpRequestEnricher

[serilog-web]

Request for new functionality in HttpRequestEnricher

[mrstebo]

I had the exact requirements for this kind of thing. So I created a separate enricher that you can add if you need it.

https://github.com/ekmsystems/serilog-enrichers-correlation-id

But as has already been mentioned, this is probably not the scope of this particular project. So better to leave it as an another dependency of your own project 👍

[nblumhardt]

Hi @asierrollograbe - thanks for the suggestion. Given the different semantics in your scenario - you're propagating activity is, not collecting a single unique id for the handling of a single HTTP request - would it be reasonable to just create a new, custom, ActivityIdEnricher for this? Cheers!

[asierrollograbe]

Thank you for your suggestion
Wouldn’t it be interesting to have this functionality in the library? It seems to be a common scenario, I’m sure it will be useful.
Would there be any problem if I update the project with my solution?
Kind regards.

[nblumhardt]

Propagating correlation ids like this is definitely interesting and worthwhile, but I think this project should stick a bit closer to the raw HTTP request handling infrastructure rather than add anything higher-level.

Would a possible alternative be:

    Enrich.WithHttpHeader("X-Some-Header", "PropertyName")

This would fit with the goals here, and hopefully cover the ActivityId scenario cleanly, too. What do you think?

[asierrollograbe]

Thanks mrstebo , it's very useful to me.