serilog/serilog-enrichers-thread

Enrich Serilog events with properties from the current thread.

serilog-enrichers-thread's Issues

Allow enriching with ThreadId on all threads except 1

In a lightly multithreaded application it might be useful to remove ThreadId=1 (or a configurable ID if needed) to decrease noise in logs and leave the IDs only for non-main threads.

ThreadName enricher

Hi,

would you mind an additional enricher which adds the thread name?

I would start with the implementation after merging #9 .

“Guid should contain 32 digits” serilog error even when a valid guid is used

We are experiencing a number of cases when we see an error with this kind of stack trace:
2020-04-20T08:38:17.5145399Z Exception while emitting periodic batch from Serilog.Sinks.MSSqlServer.MSSqlServerSink: System.ArgumentException: Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).Couldn't store <"7526f485-ec2d-4ec8-bd73-12a7d1c49a5d"> in UserId Column. Expected type is Guid.
---> System.FormatException: Guid should contain 32 digits with 4 dashes (xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx).
at System.Guid.GuidResult.SetFailure(Boolean overflow, String failureMessageID)
at System.Guid.TryParseExactD(ReadOnlySpan1 guidString, GuidResult& result) at System.Guid.TryParseGuid(ReadOnlySpan1 guidString, GuidResult& result)
at System.Guid..ctor(String g)
at System.Data.Common.ObjectStorage.Set(Int32 recordNo, Object value)
at System.Data.DataColumn.set_Item(Int32 record, Object value)
--- End of inner exception stack trace ---
at System.Data.DataColumn.set_Item(Int32 record, Object value)
at System.Data.DataRow.set_Item(DataColumn column, Object value)
at Serilog.Sinks.MSSqlServer.MSSqlServerSink.FillDataTable(IEnumerable1 events) at Serilog.Sinks.MSSqlServer.MSSqlServerSink.EmitBatchAsync(IEnumerable1 events)
at Serilog.Sinks.PeriodicBatching.PeriodicBatchingSink.OnTick()

This arises when using LogContext.PushProperty("UserId", someGuid);
someGuid is a Guid type variable, and contains a valid Guid.

It is not easily reproducible, unfortunately, but the end result is that our log entries are not being written when this kicks in.

I posted on StackOverflow some months ago with this issue, but have been unable to resolve it satisfactorily.

Wondering if there was any insight that could be offered? I'm not sure if it is an issue with serilog-enrichers-thread or with the sql server sink. I'm starting here, as the issue only arises in connection with items added with PushProperty.

Edited to Add:
This stackoverflow link from 4 years ago seems related: https://stackoverflow.com/questions/35178415/unable-to-log-in-ms-sql-using-serilog

Expired Nuget API key?

It looks like the CI builds for the dev branch are failing because the nuget API key has expired.

README needs installation/usage example