serp1412/lazytransitions

Lazy pop and dismiss like in the Facebook, Instagram or Twitter apps.

lazytransitions's Issues

to use a none fullScreen modalPresentationStyle,i get black screen while controller dismiss

i try to fix it:

if fromVC.modalPresentationStyle == .fullScreen {
containerView.insertSubview(toVC.view, belowSubview: fromVC.view)
}

add it in the DismissAnimator.swfit

UI flickering issue

Hello,

I have tried with this code, it is really nice but facing one problem. The UI flickers when swipe to dismiss.

Same happening while tapping on button "Dismiss Demo" and try to swipe left to right to dismiss. The view sometime flickers.

Not sure where it goes wrong, Was checking how other library does it smooth like https://github.com/lkzhao/Hero

But not able to find better solution for it, I have found something in their code but not sure how it is working, here is the screenshot.

File: HeroTransition+Start.swift

Please let me know if required more info.

Thanks
Hiren

Custom Presentation Controller

Hi there,

This library is really neat, I'm enjoying trying it out, but running into an issue that I can't seem to think of a way around. I'm attempting to achieve an effect like this. I'm trying to make LazyTransitioner and a UIPresentationController work nicely together to achieve an effect like this.

I tried following the README's advice of doing this instead of forward the animator and interactor properties, but it's not working because of the situation below.

func animationController(forDismissed dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    // ... pass the animator
    return transitioner.animator
}
    
func interactionControllerForDismissal(using animator: UIViewControllerAnimatedTransitioning) -> UIViewControllerInteractiveTransitioning? {
    // ... pass the interactor
    return transitioner.interactor
}

But the problem is that I still need my own implementation of func animationController(forDismissed dismissed: UIViewController) to properly dismiss.

func animationController(forDismissed dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    return MyCustomTransition(isReversed: true, duration: 0.4)
}

My suggestion would be to be able to pass in a custom UIPresentationController which can be used in conjunction with the transitioner, though I'm a bit fuzzy on the implementation.

I would love to figure out if this is currently possible, and if not, find out if it's possible to add in the future.

Thanks a lot!