sevenval/frontend-configs

Various configuration files for frontend tools

frontend-configs's Issues

eslint-config-sevenval - Warning: React version

This warning is thrown

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration

Input from @marvinhagemeister "... if applicable, we could fix this directly in the preset ..."

TSLint will be depcrecated during 2019, create equivalent eslint rules

See: palantir/tslint#4534
TSLint will be deprecated, ESLint will succeed TSLint for TS linting.

Equivalent ESLint configs should be created to enable a smooth transition.

Deprecate npm packages

As of now, installing e.g. sevenval-config-eslint via npm does not throw a deprecation warning. It would be good to have a warning that informs about the superseding packages.

eslint-config-sevenval peer dependencies

Installation as documented:

$ npm install --save-dev eslint eslint-config-sevenval
npm notice created a lockfile as package-lock.json. You should commit this file.
  npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

+ [email protected]
+ [email protected]
added 207 packages from 142 contributors and audited 451 packages in 20.981s
found 0 vulnerabilities

It is not possible to lint your files with this config without having the peer dependencies installed:

$ eslint foo.js
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.

I guess it is a good idea to remove the peer dependencies.

prettierrc shouldn't set trailingComma to "all"

trailing commas on function signatures are not spec conform whereas the ie11 throws a syntax error when it finds that. this will work only if a babel pre-processor is used for building applications, which then in return removes the trailing commas.

in my opinion it would make more sense to set this option to "es5" which sets the trailing comma only for objects and arrays but keeps the function signature clean.