seveves/ngx-translate-zombies

finds unused translation keys in your project

Hi there 👋

ngx-translate-zombies's Issues

False positives on variables

Two use cases:

1. When defining translation strings within enums

export enum GPSFieldType {
  LOCATION = 'LV.GPS_INFO.LOCATION',
  MANUAL_DEPTH = 'LV.GPS_INFO.MANUAL_DEPTH',
  ...
  ...
  ...
}

which we use to more easily access specific translations.
2. When defining translation strings within objects

        options: [
          {
            title: 'LV.SYSTEM_MAPPING.INTERNAL_GPS',
            value: NeedQPSQualityKey.InternalGPS,
          },
]

In both cases translations are marked as zombies

False positive for dynamically constructed keys

Hi there 👋,

first of all: thanks for this project, really nice to find zombies so easily.

However I've ran into some false positives. I am sure this isn't an easy issue to solve, but wanted to report it nevertheless.

Example code snippets:

<p class="error">{{'LOGIN.ERROR.' + (loginCode | async) | translate}}</p>

(Where loginCode is a string from a selector.)

Another example:

	getFilterName(filter: WalksheetFilter) {
		const name = WalksheetFilterType[filter.type];
		return this.translate.instant(`WALKSHEET.ACTIONBAR.FILTER.${name}`);
	}

ngx-translate-zombies marks these keys (like LOGIN.ERROR.NOT_AUTHORIZED) as a zombie, but they are definitively used via the dynamic key construction.

Any ideas how to solve this?

getting a whole translation object can't be recognized

when getting a translation object with the TranslateService then you have access to its properties but this is not recognized by the extension and will be removed in the diff.

this.translateService.get('MANY.KEYS')
  .pipe(take(1))
  .subscribe(keys => {
     console.log(keys['MISSING']; // no zombie at all!
   });