sgfgov/medusa-strapi-repo

Monorepo for all Strapi components to sync with medusa

medusa-strapi-repo's Issues

node-gyp

Describe the bug
node-gyp error

Console:

[email protected] build-release
node-gyp rebuild --release

gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | win32 | x64
gyp info find Python using Python version 3.12.1 found at "C:\Users\User\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\python.exe"
gyp ERR! find VS
gyp ERR! find VS msvs_version was set from command line or npm config
gyp ERR! find VS - looking for Visual Studio version 2019
gyp ERR! find VS running in VS Command Prompt, installation path is:
gyp ERR! find VS "C:\Program Files\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - will only use this version
gyp ERR! find VS checking VS2019 (16.11.34407.143) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS checking VS2019 (16.11.34407.143) found at:
gyp ERR! find VS "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools"
gyp ERR! find VS - found "Visual Studio C++ core features"
gyp ERR! find VS - found VC++ toolset: v142
gyp ERR! find VS - found Windows SDK: 10.0.19041.0
gyp ERR! find VS - does not match this Visual Studio Command Prompt
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS msvs_version does not match this VS Command Prompt or the
gyp ERR! find VS installation cannot be used.
gyp ERR! find VS
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS
gyp ERR! configure error
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack at VisualStudioFinder.fail (D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack at D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\find-visualstudio.js:74:16gyp ERR! stack at VisualStudioFinder.findVisualStudio2013 (D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack at D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\find-visualstudio.js:70:14gyp ERR! stack at D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack at D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack at D:\medusa-strapi-repo\node_modules@lerna\add\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack at ChildProcess.exithandler (node:child_process:430:5)
gyp ERR! stack at ChildProcess.emit (node:events:517:28)
gyp ERR! stack at maybeClose (node:internal/child_process:1098:16)
gyp ERR! System Windows_NT 10.0.19045
gyp ERR! command "C:\Program Files\nodejs\node.exe" "D:\medusa-strapi-repo\node_modules\@lerna\add\node_modules\node-gyp\bin\node-gyp.js" "rebuild" "--release"
gyp ERR! cwd D:\medusa-strapi-repo\node_modules\better-sqlite3

Error while executing: npx create-strapi-app strapi-medusa --template https://github.com/Kyle772/strapi-medusa-template.git

Describe the bug
When I run: npx create-strapi-app strapi-medusa --template https://github.com/Kyle772/strapi-medusa-template.git
I got that error:
ApplicationError: The type is required at getFieldSize (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/field-sizes.js:57:15) at getDefaultFieldSize (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/utils/configuration/layouts.js:34:10) at appendToEditLayout (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/utils/configuration/layouts.js:139:27) at createDefaultEditLayout (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/utils/configuration/layouts.js:56:10) at createDefaultLayouts (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/utils/configuration/layouts.js:40:11) at createDefaultConfiguration (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/utils/configuration/index.js:26:20) at async generateNewConfiguration (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/configuration.js:53:36) at async Promise.all (index 13) at async Object.syncConfigurations (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/services/configuration.js:67:5) at async Object.module.exports [as bootstrap] (/Users/yaya/Documents/projects/strapi-medusa/node_modules/@strapi/plugin-content-manager/server/bootstrap.js:7:3) { details: {} }

To Reproduce
Steps to reproduce the behavior:

1. Go to 'the terminal and run the command'

Expected behavior
Expected to execute without any error

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Device: [MacBook Air m1]
• OS: [macOS 13.0.1]
• Browser [safari, chrome]

when create product with variant there is no relationship between the product and the variant

Describe the bug
when create product with variant there is no relationship between the product and the variant

To Reproduce
Steps to reproduce the behavior:

1. Go to medusa admin
2. Create product with variant
3. Save the product
4. Go to strapi and check the new product

Expected behavior
A relation between the product and the variant

If I saved the product and then edit it and add variant the relations work as well

Medusa plugin can't decode jwt request

Describe the bug
When create a product on strapi. I got this error:
Error occur while receiving strapi signal - invalid signature

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Strapi/Content Manager/Product'
2. Create a product
3. See error

Expected behavior
A request is sent to medusa backend and a medusa product is created

Screenshots

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=16.x.x". Got "18.18.0"

Describe the bug
A clear and concise description of what the bug is.

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14.19.1 <=16.x.x". Got "18.18.0"
error Found incompatible module.

To Reproduce
Steps to reproduce the behavior:

1. Delete from packages or update with relevent on

Expected behavior
A clear and concise description of what you expected to happen.
yarn install work fine
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Error creating a product on strapi through medusa

Hello!

I have fully connected my medusa to my strapi project, and whenever I create a product through the medusa admin/api, i get the following in the logs:

info: Endpoint Attempted: http://localhost:1337/api/products,data:
error: Error occur while sending request to strapi: {"error.message":"Request failed with status code 400 ","request":{"url":"http://localhost:1337/api/products","data":"{\"title\":\"asd'kasdfas\",\"subtitle\":null,\"description\":null,\"handle\":\"asdkasdfas\",\"is_giftcard\":false,\"status\":\"published\",\"thumbnail\":null,\"weight\":null,\"length\":null,\"height\":null,\"width\":null,\"hs_code\":null,\"origin_country\":null,\"mid_code\":null,\"material\":null,\"collection_id\":null,\"type_id\":null,\"discountable\":true,\"external_id\":null,\"metadata\":null,\"images\":[],\"product_type\":null,\"product_tags\":[],\"product_options\":[],\"product_variants\":[],\"product_collection\":null,\"product_categories\":[],\"medusa_id\":\"prod_01HT28P9C7Y179RXJEAT6NRQ84\"}","method":"post"},"response":{"body":"{\"data\":null,\"error\":{\"status\":400,\"name\":\"ValidationError\",\"message\":\"Missing \"data\" payload in the request body","details":{}}}","status":400}},data:

and in the strapi logs, it returns:

[2024-03-28 13:15:53.771] http: POST /api/products (2 ms) 400

What causes this? I tried making a small postman request to the strapi such as:

{
"data": {
"title": "test "
}
}

and it works just fine, is medusa not sending the request body in json format somehow? help would be much appreciated!

Can we move the packages (especially medusa-strapi) to separate repos?

Intro

Hi, I've started using a couple of your packages from this repository in my own strapi / medusa containerised application, and would like to try porting your medusa-strapi package to Strapi v5, which is currently in beta.

What I'm doing

I'm running the medusa-strapi package in its own docker container, and am currently working through various package version dependency incompatibilities, i.e. when using yarn on a node:20-alpine docker image.

To run medusa-strapi in its own container, I'm doing an intermediate build, running git clone --depth=1 [...] on your full repo, then just copying out the medusa-strapi package out of it into the final image, which is a bit messy in itself.

Proposal

I'd like to work on a strapi-v5 branch of the medusa-strapi package, with it in its own repo. You're obviously the author, and I don't think it's possible to create a pull request for a whole new repo, otherwise I'd offer to do so. Would you be willing to create a separate medusa-strapi repo and copy the existing code into it? If I have any success making it work with Strapi v5, I'd be happy to try and contribute.

Git Submodules

I think it makes sense to have the separate packages as git submodules anyway, as they each have their own dependencies and package.json versions. Then the code wouldn't be duplicated across repositories.

Caveat

It might break some, or a lot of CI/CD implementations that don't use the --recurse-submodules argument when cloning your parent repository.

Is this something you'd be willing to do?

Thanks and kind regards,
Alex

PS. Great project by the way! I'd be happy to help with some documentation formatting on that medusa-strapi package while working on it as well, by the way 🙂

Create New App - Strapi for medusa

Bug Description
The type is required

To Reproduce
Steps to reproduce the behavior:

1. create a new strapi app with the template
2. run with yarn develop or npm run develop

Expected behavior
See an admin ui @strapibaseurl

Screenshots

Desktop (please complete the following information):

• OS: windows11
• Browser: chrome
• Node - v20.10.0

Additional Context
Could see that this is from content-manager plugin

Attempt to update admin interface language options causes blank screen

Describe the bug
After successful setup of Medusa backend with strapi plugin, I tried to update the available admin panel languages as outlined in the strapi docs. After building medusa-strapi again and firing up the dev server, localhost:1337 gives me a blank screen.

To Reproduce
Steps to reproduce the behavior:

1. Go to medusa-strapi-repo/packages/medusa-strapi/src/admin and rename app.example.js to app.js
2. Remove all of the options in locales except for zh-Hans and zh and uncomment those two options.
3. Go back to root directory and run yarn build
4. cd packages/medusa-strapi/ and run npm run develop
5. Try localhost:1337

Expected behavior
I expected the Strapi admin panel to be available in the languages I indicated in the locales - "zh", "zh-Hans" - and to find those two options in the dropdown menu in Profile.

Desktop (please complete the following information):

• OS: Mac Sonoma 14.4
• Browser: Chrome Version 122.0.6261.129 (Official Build) (arm64)

Product on Strapi disappear after deleting on Medusa

Describe the bug
When I delete a product on Medusa's backend, all of the products on Strapi will disappear. I am not sure if this also happens for other data like categories or so on.

To Reproduce
Steps to reproduce the behavior:

1. Go to Medusa Admin Dashboard
2. Delete a product
3. See all the products on Strapi disappear.

Expected behavior
Only the product deleted on Medusa was removed on Strapi.

Running yarn run build according to the steps results in an error.

strapi-plugin-medusa: Add content types and controllers

Currently you have to either use the strapi medusa template or create all the content types yourself. I think it would be good if the content types would be added to the plugin such that to add medusa to a strapi installation, it is as easy as installing the plugin.

For existing users of the plugin it shouldn't be that hard to migrate since you can use strapi's extension folder to overwrite the plugin's content types.

Update products via Strapi: Error occur while receivng strapi signal

Describe the bug
I just tried to use the Strapi admin panel to update product details for a product. The update works in Strapi, but when I go to the Medusa admin panel I do not see the changes. The terminal for the Medusa server shows an error (see 'Code').

To Reproduce
Steps to reproduce the behavior:

1. Update product title field in Strapi admin panel
2. Press "Save"
3. See error in terminal

Expected behavior
Medusa admin panel to show the new updates to the product that I updated via Strapi

Code

::1 - - [17/Mar/2024:08:19:23 +0000] "HEAD /health HTTP/1.1" 200 2 "-" "axios/0.27.2"
info:    Received POST /strapi-signal from ::1
error:   Error occur while receiving strapi signal.
{ 'error.message': 'invalid signature' }

Desktop (please complete the following information):

• OS: MacOS
• Browser: Chrome
• Version: "strapi-medusa-repo": 4.6.6, "

ValidationError while try to add field to product content

ValidationError while try to add field to product content

I try to add another field to product content and after save with my change I got ValidationError,
{
"path": [
"contentType",
"attributes",
"product-documents"
],
"message": "Attribute name 'product-documents' must match the following regex: /^[A-Za-z][_0-9A-Za-z]*$/",
"name": "ValidationError"
}

After changing all relation field to product_ instead product- e.g. product_documents instead product-documents I successfully saved the content with my new field.

Updates take longer than expected

Describe the bug
For some reason, updates with nested relations take exceptionally long. This slows down performance.
To reproduce, download the repo and run the integration tests with debug logging

*.d.ts files are missing in build output from version 5.1 of medusa-plugin-strapi-ts

Describe the bug
Since version 5.1. of medusa-plugin-strapi-ts, there are no .d.ts files in the build output. This causes an issue within medusa, for example, if we're referring to this library from medusa subscribers.

To Reproduce
Steps to reproduce the behaviour:
Compare npm output between versions 5.0 and 5.1 of medusa-plugin-strapi-ts package

when rebuilding a project getting an error

Describe the bug
so i have taken a clone with
git clone https://github.com/SGFGOV/medusa-strapi-repo.git

and made the configuration, for the first time it's working fine but when I am rebuilding or after installing any new plugin into strapi like I was trying to add CKEditor into strapi, start getting the below error during npm run build or npm run develop

➜ medusa-strapi git:(development) ✗ npm run develop

[email protected] develop
strapi develop

Building your admin UI with development configuration...
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './strapi-admin.js' is not defined by "exports" in medusa/backend/node_modules/@strapi/plugin-content-manager/package.json
at new NodeError (node:internal/errors:405:5)
at exportsNotFound (node:internal/modules/esm/resolve:366:10)
at packageExportsResolve (node:internal/modules/esm/resolve:713:9)
at resolveExports (node:internal/modules/cjs/loader:584:36)
at Module._findPath (node:internal/modules/cjs/loader:658:31)
at Module._resolveFilename (node:internal/modules/cjs/loader:1120:27)
at Function.resolve (node:internal/modules/helpers:188:19)
at medusa/backend/medusa-strapi-repo/node_modules/@strapi/admin/utils/create-cache-dir.js:110:55
at Array.filter ()
at createCacheDir (medusa/backend/medusa-strapi-repo/node_modules/@strapi/admin/utils/create-cache-dir.js:89:6) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
npm ERR! Lifecycle script develop failed with error:
npm ERR! Error: command failed
npm ERR! in workspace: [email protected]
npm ERR! at location: medusa/backend/medusa-strapi-repo/packages/medusa-strapi

I have tried to install the plugin into the main root or medusa-strapi-repo/packages/medusa-strapi

run command folder: medusa/backend/medusa-strapi-repo/packages/medusa-strapi

Desktop (please complete the following information):

• OS: MAC, somana 14.3.1 (23D60)
• Node.js - v18.19.1
• npm - 10.2.4

Thanks in advance.