shahata/angular-debounce

AngularJS service and directive for debounce

angular-debounce's Issues

Debounce causes double updates in validator

When using debounce="500" on an input element, my custom validate directive is fired twice for a single keypress.

In this codepen you can see that entering a single letter in the first input results in a double call to validation. Entering a char in the bottom input (without debounce), behaves normally and triggers only once: http://codepen.io/omichelsen/pen/uFoEb

Allow to be minified?

Since this is a released package via bower you should be using the dependency injection that allows this to be minified or ship with a minified version.

I can PR it in if you like.

NPM package?

It seems that users can't install angular-debounce with npm:

Unfortunately, angular-debounce name is already taken by https://www.npmjs.com/package/angular-debounce and ng-debounce also taken by https://www.npmjs.com/package/ng-debounce

Could you please publish this great package to npmjs? :) shahata-angular-debounce could be a nice name.

Thanks!

Doesn't work with input type="number"

Unfortunately the debounce directive doesn't seem to work with inputs of type="number". Triggers right away. Tested in both Firefox and Chrome. Changing the input to type="text" does use the delay.

Version for Angular 1.1.5

Hey, this debounce project is great!

Do you think you can make it work with Angular 1.1.5? Currently, it breaks on this line:

var commitSoon = debounce(function (viewValue) {

with this error:

TypeError: object is not a function

http://jsfiddle.net/efmU6

Thanks!

Please update your bower script to support newer versions of angular.

Feature Request: Trigger on both edges

Changing param "immediate" to triggerOnEgde[leading, trailing, both] would be perfect for situations like pagination. A user would not wait if he clicks just once. And if he clicks multiple times all clicks between the first and the last are not counted but he'd get the data for the last click.

Broken in 1.3.0

@shahata

The debounce is broken for version 1.3.0, check the fiddle below:

http://jsfiddle.net/9sqtvcou/1/

If you change the "external resources" to the version 1.2.27 it works.

Controller 'ngModel', required by directive 'debounce', can't be found!

This is my code

<input ng-model="chunk.userInput" debounce="500">

and I get the following error:

Controller 'ngModel', required by directive 'debounce', can't be found!

Apart from the debounce directive my input field works just fine. My model is properly updated. But it just doesn't debounce!

I'm running angular v. 1.2.25

the module name is 'rt.debounce'

readme says just 'debounce'