shakyshane/dev-ip

Find a suitable IP host to view local websites on

dev-ip's Issues

Return inside if block

I use browser-sync which use your code as a dependency. When I transpile my code with babel6 a get this error:
browser-sync/node_modules/dev-ip/lib/dev-ip.js: 'return' outside of function (41:8)

   39 |     var out = getIp();
   40 |     if (!out.length) {
 > 41 |         return console.log(messages.error);
      |         ^
   42 |     }
   43 |     console.log(getIp("cli"));
   44 | }

If I remove return from the 41th line, everything is ok.
Could you verify my statement or fix this issue. Thans a lot.

node v18.0.0 not returning local IP

Bonjour!

I use browser-sync, which uses this code as a dependency. I recently updated to node 18.0.0 without second thought and started getting the following error, where there was no external IP returned. The output looked like this:

[Browsersync] Access URLs:
 ----------------------------------
       Local: http://localhost:3000
    External: http://false:3000
 ----------------------------------
          UI: http://localhost:3001
 UI External: http://localhost:3001
 ----------------------------------

So I downloaded dev-ip, did some digging and it seems like for some reason address.family isn't returned as a string of IPv4 anymore, like in the original code, but as an integer 4.

Logging the addresses looks like this, without the unimportant bits:

{
  address: '—',
  netmask: '—,
  family: 4,
  mac: '—',
  internal: false,
  cidr: '—'
}

Any chance you could take a look? I've reverted back to node v17 in the meantime, but I feel like this problem might pop up for others as well.

I'm sorry if this isn't the most comprehensive ticket, I don't usually engage much with anything on github.

Cheers
Felix