shamshirz/scoreboard

Intro to Absinthe & Dataloader

scoreboard's Issues

Add mutation example

Question: apply param for player_id

Hey Aaron - thanks for the talk you made at the ElixirConf and making this repo available. I have a quick question about this line here:

scoreboard/lib/scoreboard/games/games.ex

Line 34 in 9d1f811

def apply_param({:player_id, player_id}, queryable),

def query(Score, params) do
    params
    |> Map.put_new(:limit, 10)
    |> Map.put_new(:order, :total)
    |> Map.to_list()
    |> Enum.reduce(Score, &apply_param/2)
  end

  def query(queryable, _params), do: queryable

  @doc """
  reduce function
  """
  def apply_param({:limit, num}, queryable), do: queryable |> limit(^num)
  def apply_param({:order, field}, queryable), do: queryable |> order_by(desc: ^field)

  def apply_param({:player_id, player_id}, queryable), #specifically this pattern
    do: queryable |> where(player_id: ^player_id)

Is the player_id pattern ever matched on in this solution? I ask because I don't see it added to the Map in the query, is the dataloader matching on this function some other way or do you need to specifically hook it up within def query(Score, params)?

Thanks again.

Add top level queries with args (limit etc)

Do `get_or_create` on player name

Means player names will be basically unique 🤷‍♂️

Make sure anyone can still do queries, but maybe only do CORS on mutations?

I still want this to be a live example app for people

Move CORS config into env var