shanepadgett/gicreator

Create custom gitignore files from Github templates.

gicreator's Issues

Length Checking Can be Simplified

    if (added.proj.length > 0 || added.global.length > 0) {
      let types = added.proj.concat(added.global)
      console.log(`Created .gitignore for [${types.join(', ')}]`)
    }

You can drop the >0 as the zero value is falsy:

    if (added.proj.length || added.global.length) {
      let types = added.proj.concat(added.global)
      console.log(`Created .gitignore for [${types.join(', ')}]`)
    }

Also not necessary to set an intermediary variable here (depending on your preference):

    if (added.proj.length || added.global.length) {
      console.log(`Created .gitignore for [${added.proj.concat(added.global).join(', ')}]`)
    }

Take Advantage of Promise Chaining

In the following code block, you can take advantage of promise chaining by returning the fetch calls to avoid nesting promise chains:

fetch("https://api.github.com/repos/github/gitignore/contents", props)
    .then(res => res.json())
    .then(json => {
        types.projectTypes = extractResponseNames(json)

        return fetch(
            "https://api.github.com/repos/github/gitignore/contents/Global",
            props
        )
    })
    .then(res => res.json())
    .then(json => {
        types.globalTypes = extractResponseNames(json)
        resolve(types)
    })

Take Advantage of Higher-Order Functions for Atomic Changes

    reqTypes.forEach(item => {
      item = item.toLowerCase()
      let lowerCaseProjectTypes = availableTypes.projectTypes.map(value => value.toLowerCase())
      let lowerCaseGlobalTypes = availableTypes.globalTypes.map(value => value.toLowerCase())
      
      if (lowerCaseProjectTypes.indexOf(item) !== -1) {
        added.proj.push(availableTypes.projectTypes[lowerCaseProjectTypes.indexOf(item)])
      } else if (lowerCaseGlobalTypes.indexOf(item) !== -1) {
        added.global.push(availableTypes.globalTypes[lowerCaseGlobalTypes.indexOf(item)])
      } else {
        missing.push(item)
      }
    })

This is totally up to you depending on how you prefer to structure things, but it seems like you're embracing the functional style and using higher order functions where available. You can use a .map() here to handle the atomic change (toLowerCase) on each option. You can also use the ES6 Array.includes to clean up some of the messy !== -1 checking.

This is definitely more of a preference kind of thing so feel free to just close this one if you prefer. The (very small) changes I'd recommend are the following:

    reqTypes
     .map(item => item.toLowerCase())
     .forEach(item => {
      let lowerCaseProjectTypes = availableTypes.projectTypes.map(value => value.toLowerCase())
      let lowerCaseGlobalTypes = availableTypes.globalTypes.map(value => value.toLowerCase())
      
      if (lowerCaseProjectTypes.includes(item)) {
        added.proj.push(availableTypes.projectTypes[lowerCaseProjectTypes.indexOf(item)])
      } else if (lowerCaseGlobalTypes.includes(item)) {
        added.global.push(availableTypes.globalTypes[lowerCaseGlobalTypes.indexOf(item)])
      } else {
        missing.push(item)
      }
    })

Take Advantage of Explicit Return

The above functions (map and filter) can be simplified to take advantage of ES6 implicit return, e.g:

    const extractResponseNames = data => data.map(obj => obj.name.substr(0, obj.name.indexOf(".")))
        .filter(elm => elm)

macOS does not return a .gitignore template

The macOS request returns a 404. Likely to do with the difference in capitalization.

Don't write to file on 404 Not Found

I'm not certain what your preferred way of handling unfound ignore packages is, but for these that are dumping "404 not found" it would probably be best to leave them blank instead of pushing the 404 message into the template.

The Mac one should at minimum (and probably only) blacklist .DS_Store's in every directory.

Migrate from Node-Fetch to Axios

After research, Axios looks to be the simpler library to use which also supports promises.