Giter Site home page Giter Site logo

shape-and-shift / shopware-variant-switch Goto Github PK

View Code? Open in Web Editor NEW
17.0 17.0 12.0 45 KB

Shopware plugin to show a variant switch on the product listing and within the (checkout) cart.

License: MIT License

JavaScript 14.42% SCSS 3.87% Twig 31.05% PHP 50.66%
shopware shopware6 shopware6-plugin

shopware-variant-switch's People

Contributors

azngeek avatar christopherdosin avatar hungmac-sw avatar vienthuong avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

shopware-variant-switch's Issues

6.4.12 compablity

On Shopware 6.4.12 there seems to be a compatibility issue:

request.CRITICAL: Uncaught PHP Exception TypeError: "SasVariantSwitch\Storefront\Page\ProductListingConfigurationLoader::isCombinable(): Argument #3 ($combinations) must be of type Shopware\Core\Content\Product\SalesChannel\Detail\AvailableCombinationResult, null given, called in /www/htdocs/w007fddd/[shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php](http://shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php) on line 72" at /www/htdocs/w007fddd/[shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php](http://shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php) line 280 {"exception":"[object] (TypeError(code: 0): SasVariantSwitch\\Storefront\\Page\\ProductListingConfigurationLoader::isCombinable(): Argument #3 ($combinations) must be of type Shopware\\Core\\Content\\Product\\SalesChannel\\Detail\\AvailableCombinationResult, null given, called in /www/htdocs/w007fddd/[shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php](http://shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php) on line 72 at /www/htdocs/w007fddd/[shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php:280](http://shop.easy-to-run.de/custom/plugins/SasVariantSwitch/src/Storefront/Page/ProductListingConfigurationLoader.php:280))"} []

Multiple sale channel languages bug.

There is a bug for multiple language channels.

When we have at least 2 domains for one channel there is a problem with changing variant on the listing page. When our sales channel have default English language and we are currently on any other like here:

image

When we change variant the link to the product also changes to the English version (default):

image

Invisible variant shown on product list

Problem description

On the product list all variants are shown, including those that have been excluded for the current sales channel.
The product detail page shows only variants which are actually visible for the current sales channel.

Steps to reproduce

  1. Create two sales channels, for example pointing to different subdomains.
  2. Create a product with a few variants.
  3. For a certain variant change visibility, removing one sales channel.
  4. See the behavior:
    1. Open product list to see it still shows the variant that should be hidden now.
    2. When switching to this variant the entire product is hidden.
    3. When opening the product detail page the variant is not shown.

Hide split variants (Feature Request)

Currently, all variants are displayed on the article. However, if the articles are split in the listing, you will see all variants multiple times. Once as a single article and once as a variant selector.
grafik

Here an option would be helpful, which shows only the variant attributes on the article for selection, which are not already split.
In this example, in the category the variants are split by color and the sizes are available for selection:
grafik

Beim erstes anzeigen wird "is-combinable" eingefügt

Hey,
ich habe euer Plugin "Varianten switch im Product Listing" im Einsatz.
Ich weiß das ihr kein Support dafür habt.
Aber vielleicht hat jemand von euch Lust drauf.

Ich glaube das Plugin hat einen kleinen Bug.
Bei dem ersten laden der Seite wird bei jeder Auswahl "is-combinable" als CSS classe hinzugefügt.
Kann man schön beobachten wenn man ein Produkt hat was mehrere Auswahl Kriterien hat. (bei mir, T-Shirt größe, T-Shirt Farbe und T-Shirt aufdruck_farbe)

Vielleicht hat ja mal wer Zeit zum nachschauen.

Liebe Grüße
Martin

Bug add extension on null

in one of our Shopware 6 shops we have two other plugins active in addition to your plugin.

That would be “shopping cart free products / goals | by 28minds” and “Award Items”. As soon as a free product or a bonus item (using these plugins) is placed in the shopping cart, your plugin will issue an error message. In the CartPageLoadedSubscriber.php file, in line 122 of the addLineItemPropertyGroups function, the $lineItem parameter is set to zero, which leads to an error. Would it be an option here to include an if statement that checks whether $lineItem !== is null?

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.